Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implemented onFinish attribute for CallFlowRecordStep #54

Merged
merged 2 commits into from Jan 9, 2020
Merged

implemented onFinish attribute for CallFlowRecordStep #54

merged 2 commits into from Jan 9, 2020

Conversation

zeddee
Copy link
Contributor

@zeddee zeddee commented Oct 22, 2018

Implemented onFinish attribute for step[].options (https://developers.messagebird.com/docs/voice-calling#call-flows) as

CallFlowRecordStep struct{
  // ...
  OnFinish string
}

This is required for chaining call flows while staying on the same callID/legID. A specific example would be how onFinish is used here: https://github.com/messagebirdguides/automated-surveys

@zeddee
Copy link
Contributor Author

zeddee commented Oct 24, 2018

this PR addresses #57

@marcelcorso
Copy link
Contributor

@yevgenypi likes this 👍

@marcelcorso marcelcorso merged commit 1dbb310 into messagebird:master Jan 9, 2020
@marcelcorso
Copy link
Contributor

thanks @zeddee!!! Sorry it took ages to take a look at this PR. <3

@zeddee
Copy link
Contributor Author

zeddee commented Jan 10, 2020

getting a notification for this made me chuckle :) glad you found it useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zeddee @marcelcorso