⬆️ Provide support for PHP 8. #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmichot
commented
Mar 8, 2021
| $this->expectException(\InvalidArgumentException::class); | ||
| $this->expectExceptionMessageRegExp('/^Timeout must be an int > 0, got "integer 0".$/'); | ||
| $this->expectException(InvalidArgumentException::class); | ||
| $this->expectExceptionMessage('Timeout must be an int > 0, got "integer 0"'); |
There was a problem hiding this comment.
expectExceptionMessageRegExp can be safely replaced by expectExceptionMessage as per the phpunit/phpunit package upgrade.
There was a problem hiding this comment.
And this actually also enforces a stricter assertion 🚀
|
I will rebase this PR and fix the conflicts to get it ready to be merged ASAP @CoolGoose |
|
@lucasmichot Thanks! Since this is a breaking change, we're assessing our versioning strategy. |
|
You're welcome @rfeiner 👌🏽 ! |
|
Thank you @lucasmichot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides much-needed support for PHP 8.
At the moment only PHP versions 7.0 to 7.4 are supported, which is not optimal for client adoption. Indeed, many projects already require PHP version 8 as a platform dependency.
Also, this PR drops support for version below 7.3. As planned within the supported PHP versions timeline, the PHP 7.2 version does not receive security fixes since November 2020.
It is thus safe to deprecate the support of these versions.
Note:
a new major release for this client will have to be published (on Github and Packagist)
/cc @bviolier @rfeiner @CoolGoose