Add additional properties to Recipient object #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The REST API returns attributes not included in the `Recipient` object. This PR adds additional attributes with one exception; pricing information.
dennisvdvliet
force-pushed
the
additional-recipient-properties
branch
from
6fa5e27
to
e30938f
Compare
dennisvdvliet
force-pushed
the
additional-recipient-properties
branch
from
e30938f
to
0cf4612
Compare
dennisvdvliet
added a commit
to dennisvdvliet/php-rest-api
that referenced
this pull request
Jan 18, 2022
On every pull request we run psalm using a GitHub action. The GitHub action was using the `latest` version of psalm. On this [1] PR that resulted in psalm passing locally but breaking in the PR. This pins the version of psalm in composer and in the GitHub action to 4.18.1. [1] messagebird#186
CoolGoose
pushed a commit
that referenced
this pull request
Jan 19, 2022
* Pin psalm version * Pin psalm to 4.18.1 On every pull request we run psalm using a GitHub action. The GitHub action was using the `latest` version of psalm. On this [1] PR that resulted in psalm passing locally but breaking in the PR. This pins the version of psalm in composer and in the GitHub action to 4.18.1. [1] #186 Co-authored-by: Dennis van der Vliet <dennis.vandervliet@messagebird.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The REST API returns attributes not included in the
Recipientobject. This PRadds additional attributes with one exception; pricing information.