Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mutable default value with sentinel #12

Merged
merged 3 commits into from
Nov 29, 2017

Conversation

sebastiaanMB
Copy link
Contributor

replaced all params={} with params=None and
if params is None: params = {}

see: https://docs.quantifiedcode.com/python-anti-patterns/correctness/mutable_default_value_as_argument.html

@sebastiaanMB
Copy link
Contributor Author

@dstotijn kan je me helpen met testen?

@samwierema samwierema changed the title WIP: fix mutable default value with sentinel Fix mutable default value with sentinel Nov 29, 2017
@samwierema samwierema added the bug label Nov 29, 2017
@samwierema samwierema merged commit 19250ff into master Nov 29, 2017
@samwierema samwierema deleted the fix_mutable_default_value branch November 29, 2017 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants