Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Since 0.1.7 Compilation Failure #38

Closed
iammerrick opened this issue Feb 21, 2014 · 4 comments
Closed

Since 0.1.7 Compilation Failure #38

iammerrick opened this issue Feb 21, 2014 · 4 comments

Comments

@iammerrick
Copy link
Contributor

MessageFormat appears to be compiling a global function "p" that doesn't exist in the outputted file? This wasn't a problem before but recently started showing up in our builds.

(function(){ window.i18n || (window.i18n = {}) 
var MessageFormat = { locale: {} };
MessageFormat.locale.en=function(n){return n===1?"one":"other"}
window.i18n["admin"]["page"] = function(d){return p(d,"count",0,"en",{"one":"Page","other":"Pages"})}

Any idea as to what that global p function could be?

@SlexAxton
Copy link
Member

Yea. I think as you mentioned in #34 this is almost definitely because of the recent changes. /cc @eemeli

Perhaps just stay on 1.6.x until we get that worked out. All the good bug fixes were there. The only thing you're missing out on is positional arguments instead of named ones (and generated file size improvements).

@iammerrick
Copy link
Contributor Author

@SlexAxton I think it is because of the grunt plugin I was using circumvented the CLI which consequently misses out on the messageformat.include.js Not your guys fault but a combination of a loosely tied version between grunt-messageformat and messageformat.

@SlexAxton
Copy link
Member

Ah, you wanna close this one and open an issue on grunt-messageformat, or you think it's specific to you?

@iammerrick
Copy link
Contributor Author

It is definetly not your guys fault, just took me a bit to discover that. semver pain. Thanks for the awesome work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants