Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpc not parsing MessagePackObject contained in .Net Core class library projects correctly #42

Closed
YuandongLi opened this issue Apr 20, 2017 · 5 comments

Comments

@YuandongLi
Copy link

I tried to use mpc to generate resolvers for some of my classes marked with MessagePackObject attribute from a .Net Core class library project.
However, GeneratedResolverGetFormatterHelper.GetFormatter(Type) in the resulting file only contains an empty switch statement which is different from what I got by generating from a ,Net console application project.
When I built mpc from source and attached a debugger to it, I found that when generating from a .net Core class library project, it throws an exception. The exception indicates the constructor parameter is empty for MessagePackObjectAttribute and KeyAttribute when supplying with a csproj file from a .net Core class library project.
It looks like Roslyn fails to parse those construct parameters in this case.

Is there something you could do fix it? Thanks!

@Rurouni
Copy link

Rurouni commented Apr 20, 2017

Feels similar to #23
I don't think author can easily fix that issue because MSBuildWorkspace is not working as it should yet dotnet/roslyn#17974

@YuandongLi
Copy link
Author

@Rurouni Agree. Just wonder if the author has any workarounds in mind though.

@neuecc
Copy link
Member

neuecc commented Apr 21, 2017

Thank you.
I do not have expectations for updating MSBuildWorkspace.
It is necessary to migrate that can be handled itself.
But it need a little more time.

@neuecc neuecc mentioned this issue Aug 31, 2017
18 tasks
@neuecc
Copy link
Member

neuecc commented Dec 22, 2017

support for mono, set Environment path, it works for new csproj, etc.
252e6db

@neuecc
Copy link
Member

neuecc commented Mar 14, 2018

related to #188 and close(discussion move).

@neuecc neuecc closed this as completed Mar 14, 2018
AArnott added a commit that referenced this issue Apr 17, 2019
AArnott added a commit that referenced this issue Mar 11, 2023
Use agent jobname for for symbols folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants