Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachment popup not showing since RC 1.3.5 #36

Closed
jockie opened this issue Jun 20, 2018 · 5 comments
Closed

Attachment popup not showing since RC 1.3.5 #36

jockie opened this issue Jun 20, 2018 · 5 comments

Comments

@jockie
Copy link

jockie commented Jun 20, 2018

Simply does not show. Shows some preventDefault-JS-Error in JS Console.

@ghost
Copy link

ghost commented Jul 18, 2018

Please, test on roundcube 1.3.6.
Write you system info:
Like this:
https://github.com/6ec123321/chbox/blob/master/README
[TEST SERVER CONFIGURATION]
ubuntu 16.04 4.4.0-116-generic
Apache/2.4.18 (Ubuntu)
PHP 5.6.34-1+ubuntu16.04.1+deb.sury.org+1 (cli)
mysql Ver 14.14 Distrib 5.7.21, for Linux (x86_64) using EditLine wrapper

or

testing on this for fast:
https://github.com/6ec123321/docker-alpine-roundcubemail-1.3.6

i'm using this docker-image in 5 internet-servers

@futureweb
Copy link
Contributor

futureweb commented Nov 30, 2018

1.3.8 - same problem when trying to open Attachment Popup ...

TypeError: a.preventDefault is not a function

seems like an incompatibility between jquery mobile and jquery version ...
Related to: jquery/jquery#2917 I guess ...

mhm ?!?

@futureweb
Copy link
Contributor

That's what I did to get File Upload working again (temporary fix):

replace minified Version with unminified:

  • mv plugins/jquery_mobile/js/jquery.mobile-1.4.5.min.js plugins/jquery_mobile/js/jquery.mobile-1.4.5.min.js.orig
  • cp plugins/jquery_mobile/js/jquery.mobile-1.4.5.js plugins/jquery_mobile/js/jquery.mobile-1.4.5.min.js.orig

Diff of Change:

# diff jquery.mobile-1.4.5.min.js jquery.mobile-1.4.5.js
3032c3032
<                               /*popstateEvent.originalEvent = new $.Event {
---
>                               popstateEvent.originalEvent = {
3035,3037c3035
<                               };*/
<                               popstateEvent.originalEvent = new $.Event( "popstate", { state: null } );
<                               state.id = ( this.squash( url, state ) || {} ).id;
---
>   

futureweb added a commit to futureweb/Roundcube-Plugin-JQuery-Mobile that referenced this issue Nov 30, 2018
@tpayen
Copy link
Member

tpayen commented Nov 30, 2018

Thanks, it seems to work well !
I check that everything works with this patch and I release a new version of jquery mobile plugin quickly

@tpayen
Copy link
Member

tpayen commented Nov 30, 2018

Fixed in jquery_mobile 1.2 https://github.com/messagerie-melanie2/Roundcube-Plugin-JQuery-Mobile/releases/tag/v1.2

@tpayen tpayen closed this as completed Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants