Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#bug; SDK not getting position right before close #2236

Closed
2 tasks
ishraq8 opened this issue Jun 23, 2023 · 4 comments
Closed
2 tasks

#bug; SDK not getting position right before close #2236

ishraq8 opened this issue Jun 23, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@ishraq8
Copy link
Contributor

ishraq8 commented Jun 23, 2023

Describe the bug
Position data at close shows 0, which is technically accurate but we also want to show the value of the position right before close. Can we upgrade the sdk to reflect this? Older version of GMX was doing this which @corerouter had made.

Reproduction
Where can we see this bug in action?

This is what we get:
image

This is what we might expect :
image

See discussion here for reference: #2229

Tasks

@ishraq8 ishraq8 added the bug Something isn't working label Jun 23, 2023
@bye43 bye43 assigned dhruv-chauhan and ishraq8 and unassigned bye43 Jun 23, 2023
@ishraq8
Copy link
Contributor Author

ishraq8 commented Jun 24, 2023

image

Also looks liketimestampclosed: null in some of the snapshots: #2229 (comment)

@dhruv-chauhan
Copy link
Collaborator

on it 🖖

@dhruv-chauhan
Copy link
Collaborator

Hey @ishraq8 , PR #2241 should fix this.
Deployments and example query are in the PR description. Could you please verify?

@ishraq8
Copy link
Contributor Author

ishraq8 commented Jun 28, 2023

looks like both issues were resolved. Also thank you for updating the GMX forks in the PR as well.

@ishraq8 ishraq8 closed this as completed Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

3 participants