Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#minor); gmx; fix position snapshots #2241

Merged
merged 11 commits into from
Jul 7, 2023

Conversation

@ishraq8
Copy link
Contributor

ishraq8 commented Jun 28, 2023

passed QA

@ishraq8 ishraq8 self-assigned this Jun 28, 2023
Copy link
Contributor

@melotik melotik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just 1 extra comment, can you copy all of the sdk changes over to the gmx-forks repo so we don't have some files that show the old version.

Thanks!

@ishraq8
Copy link
Contributor

ishraq8 commented Jul 6, 2023

Following discussion here: https://discord.com/channels/953684103012683796/1067631209968058408/1126475904944705626

do you think you can add inputTokens into the daily and hourly pool level time series snapshot with inputTokenBalances and inputTokenWeights in the schema and sdk.

Also update the GMX updates you have with this?

If not, no worries, i can add it after this is merged.

@dhruv-chauhan
Copy link
Collaborator Author

@ishraq8 added, and updated deployment links in the description

@ishraq8
Copy link
Contributor

ishraq8 commented Jul 7, 2023

updates to inputtokens appears to be working, thank you @dhruv-chauhan

@melotik
Copy link
Contributor

melotik commented Jul 7, 2023

@dhruv-chauhan can we also update versions for mummy-finance

@dhruv-chauhan
Copy link
Collaborator Author

@dmelotik done

@melotik melotik merged commit 7c2e215 into messari:master Jul 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants