Skip to content

Commit

Permalink
refactor adding new git hook
Browse files Browse the repository at this point in the history
  • Loading branch information
mesuutt committed Jan 7, 2023
1 parent c9885f1 commit 4670731
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 14 deletions.
5 changes: 1 addition & 4 deletions internal/command/install.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,8 @@ var InstallCmd = &cli.Command{
// InstallHookCmd add git hook to .git/hooks/post-commit file
func InstallHookCmd(c *cli.Context) error {
path := c.Path("path")
if err := git.ValidateRepo(path); err != nil {
return err
}

if err := git.CreateHookDir(path); err != nil {
if err := git.ValidateRepo(path); err != nil {
return err
}

Expand Down
25 changes: 15 additions & 10 deletions pkg/git/git.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,18 +47,12 @@ func LastCommitStatsDiff(repoPath string) ([]byte, error) {
return out, nil
}

func CreateHookDir(path string) error {
hookDir := filepath.Join(path, ".git", "hooks")
if _, err := os.Stat(hookDir); os.IsNotExist(err) {
if err := os.MkdirAll(hookDir, os.ModeDir); err != nil {
return fmt.Errorf(hookDir+" directory creation failed: %v", err)
}
// AddHook adds given content to the given hook file
func AddHook(path string, hook, content string) error {
if err := createHookDir(path); err != nil {
return err
}

return nil
}

func AddHook(path string, hook, content string) error {
// TODO: prevent duplicate hook
// TODO: in test check file is executable
hookFilePath := filepath.Join(path, ".git", "hooks", hook)
Expand All @@ -75,3 +69,14 @@ func AddHook(path string, hook, content string) error {

return nil
}

func createHookDir(path string) error {
hookDir := filepath.Join(path, ".git", "hooks")
if _, err := os.Stat(hookDir); os.IsNotExist(err) {
if err := os.MkdirAll(hookDir, os.ModeDir); err != nil {
return fmt.Errorf(hookDir+" directory creation failed: %v", err)
}
}

return nil
}

0 comments on commit 4670731

Please sign in to comment.