Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node_name field in srv Request #109

Closed

Conversation

jginesclavero
Copy link
Collaborator

Hi @marioney !

The feature/rules branch of system modes uses an old version of its service messages in which ChangeModeRequest needs the node_name field. It is not necessary (maybe you get a compilation error) if you use the master branch, but we need it if we want to show the laser failure and the battery contingency in the MROS hands-on.

  • I have added the node_name into the ChangeModeRequest message.

@marioney
Copy link
Contributor

Not sure if that's the best solution. Doesn't it make more sense to make the update in the system_modes? If it's already on master, I think it's better to change this there (else we will need to change this back soon)

I'll reopen micro-ROS/system_modes#24 to ask them to apply the change to the features/rules branch

@marioney
Copy link
Contributor

@jginesclavero This should be solved with the latest changes on the feature/rules branch of system modes micro-ROS/system_modes@5b40cf1

Can you test that, and if it works, I guess we can close this

@jginesclavero
Copy link
Collaborator Author

It works!!! Thank you 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants