Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load_model_sharded needs minor fix #87

Closed
lchu-ibm opened this issue Aug 2, 2023 · 1 comment
Closed

load_model_sharded needs minor fix #87

lchu-ibm opened this issue Aug 2, 2023 · 1 comment

Comments

@lchu-ibm
Copy link
Contributor

lchu-ibm commented Aug 2, 2023 •
edited
Loading

🐛 Describe the bug

load_model_sharded has a minor and needs a quick fix like: 1134108.

I assume this is expected to be used to pair with save_model_and_optimizer_sharded, so we need to match the dict key.

cc @HamidShojanazeri
@HamidShojanazeri
Copy link
Contributor

@lchu-ibm thanks, can you pls add it to the other PR.

lchu-ibm added a commit to lchu-ibm/llama-recipes that referenced this issue Aug 3, 2023
@lchu-ibm
address meta-llama#87
e216c6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@HamidShojanazeri @lchu-ibm