Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use 'md5' instead of 'md5sum' if Applie Silicon #727

Merged
merged 1 commit into from
Sep 1, 2023
Merged

use 'md5' instead of 'md5sum' if Applie Silicon #727

merged 1 commit into from
Sep 1, 2023

Conversation

godpeny
Copy link
Contributor

@godpeny godpeny commented Aug 28, 2023

fix the issue that checksum is not working properly in Silicon Mac.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 28, 2023
@ckxng ckxng self-assigned this Aug 31, 2023
@ckxng
Copy link

ckxng commented Aug 31, 2023

This looks useful, thanks. I have an M1 Mac to test on, I'll check and merge.

@ckxng ckxng mentioned this pull request Aug 31, 2023
Open
hatala91
hatala91 reviewed Aug 31, 2023
View reviewed changes
Copy link

@hatala91 hatala91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried this locally on an Apple M1 Pro, worked like a charm. Let's resolve that merge conflict and shipit 🚢

@godpeny godpeny force-pushed the feat/dl_script branch 2 times, most recently from 0ac7572 to 3e52031 Compare September 1, 2023 01:29
@godpeny
Copy link
Contributor Author

godpeny commented Sep 1, 2023

@hatala91
conflict resolved :-)

@ghk ghk merged commit a255a05 into meta-llama:main Sep 1, 2023
1 check passed
@godpeny godpeny mentioned this pull request Sep 1, 2023
Closed
mst272 pushed a commit to mst272/llama that referenced this pull request Mar 22, 2024
@ghk
Merge pull request meta-llama#727 from godpeny/feat/dl_script
6ca2992 
use 'md5' instead of 'md5sum' if Applie Silicon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hatala91 hatala91 hatala91 left review comments

Assignees

@ckxng ckxng

Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@godpeny @ckxng @hatala91 @ghk @facebook-github-bot