Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection Status is missed (gamepad.connected == undefined) #28

Closed
eugenner opened this issue Aug 14, 2023 · 1 comment
Closed

Connection Status is missed (gamepad.connected == undefined) #28

eugenner opened this issue Aug 14, 2023 · 1 comment
Milestone
v1.4.2

Comments

@eugenner
Copy link

EmulatedXRDevice.gamepads objects have no "connected" property.
After entering in VR mode, gamepad has property "connected" = undefined.
Modules that depend on this status may not work correctly.
@felixtrz felixtrz added this to the v1.4.2 milestone Oct 13, 2023
facebook-github-bot pushed a commit that referenced this issue Oct 13, 2023
@felixtrz @facebook-github-bot
fix(gamepad): add connected property to inputSource.gamepad
1cf6fa4 
Summary: #28

Reviewed By: cabanier

Differential Revision:
D50253731

Privacy Context Container: L1164747

fbshipit-source-id: 63c88b51ad20761614ae00054a4cc3f16357fbe5
@felixtrz
Copy link
Contributor

The fix has been landed into the main branch. If you'd like immediate access, you can build from the source to obtain the patch. Otherwise, it will be included in the upcoming v1.4.2 release.

Thank you for bringing this issue to our attention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.2
Development

No branches or pull requests
2 participants
@eugenner @felixtrz