Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input button retains state at page load before entering immersive mode #43

Closed
dmarcos opened this issue Nov 2, 2023 · 0 comments
Closed

Input button retains state at page load before entering immersive mode #43

dmarcos opened this issue Nov 2, 2023 · 0 comments
Milestone
v1.5.0

Comments

@dmarcos
Copy link

dmarcos commented Nov 2, 2023

Notice that if I press the buttons below (to switch from hands to controller or viceversa) before entering immersive mode it has no effect. It retains the option / state that had at page load. It works as expected once I enter immersive mode (I can switch from hands to controllers or viceversa)

image
@dmarcos dmarcos changed the title Input button retains state at load before entering immersive mode Input button retains state at page load before entering immersive mode Nov 2, 2023
facebook-github-bot pushed a commit that referenced this issue Dec 7, 2023
@felixtrz @facebook-github-bot
fix(input-mode): Establish connection between client-side polyfill an…
dc2a55b 
…d service worker on page load for proper handling of emulator UI actions

Summary: Resolved the issue reported in #43, where adjusting input mode before entering VR had no effect. This was caused by the client-side polyfill not automatically connecting to the IWE service worker without user action (such as entering VR). To address this, a ping is now sent upon page load and polyfill initialization, establishing a connection between the client-side polyfill and the service worker. As a result, emulator UI actions are properly received by the client-side polyfill even before entering VR.

Reviewed By: cabanier

Differential Revision: D51920505

fbshipit-source-id: edbc651e26206876fcd307439806d54f2c5ba4df
@felixtrz felixtrz added this to the v1.4.3 milestone Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.0
Development

No branches or pull requests
2 participants
@dmarcos @felixtrz