tfidf transformer #172
Merged
tfidf transformer #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me -- I don't think the caveats are bad. |
|
Ok, travis is finally done. I'm satisfied with this branch -- @skystrife , are you? |
|
I think it's fine to merge. We might want to add to the classification tutorial on the website to demonstrate how to use this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a few tranformation functions that might be useful to apply to a
learn::dataset. Specifically, this adds a function to convert the count vectors to tf-idf vectors according to someinverted_indexandranker(via itsscore_one()) and a simpler function that normalizes feature vectors to unit length.I've added some very basic unit tests for this, too.