Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"undefined" variable problem #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

MacDada
Copy link

@MacDada MacDada commented Jan 24, 2013

I have changed somevar === undefined to 'undefined' === typeof somevar.

In older browsers undefined is not a reserved keyword and could be changed by some badly written code.

Example:

// somewhere in the user's js…
undefined = "trolololo";

// your library
function test(value) {
    if (undefined !== value) {
        console.log(value); // this will log "trolololo"
    }

    if ('undefined' === typeof value) {
        console.log(value); // this won't log "trolololo"
    }
}

test();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant