Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to the README #23

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Add documentation to the README #23

merged 3 commits into from
Apr 29, 2024

Conversation

tsmacdonald
Copy link
Member

No description provided.

@tsmacdonald tsmacdonald requested a review from a team April 25, 2024 12:40
@tsmacdonald tsmacdonald self-assigned this Apr 25, 2024
Copy link

@escherize escherize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read through the readme as someone who doesn't know a ton about macaw, and left some thoughts and questions along the way. I kind of see a README as a pitch for explaining how cool the library is, so left comments from that POV. Hope that helps!

README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/macaw/core.clj Show resolved Hide resolved
@tsmacdonald tsmacdonald mentioned this pull request Apr 29, 2024
@tsmacdonald
Copy link
Member Author

Really nice review, thanks @escherize !

@tsmacdonald tsmacdonald merged commit 5eba684 into master Apr 29, 2024
4 checks passed
@tsmacdonald tsmacdonald deleted the documentation branch April 29, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants