This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
Alow datetime arithemtics via :+ clause and add :interval clause #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camsaul
reviewed
Jun 26, 2019
| ExpressionArg)) | ||
|
|
||
| (defclause ^{:requires-features #{:expressions}} + | ||
| x ExpressionArg, y ExpressionArgOrInterval, more (rest ExpressionArg)) |
There was a problem hiding this comment.
Is there a reason to not allow intervals for the more args? Or to not allow it for - as well?
There was a problem hiding this comment.
I was a bit hesitant about multiple args because date arithemtics is a bit funky and say associativity property doesn't entirely hold. But that might be more a theoretical than practical concern. Happy to add if you reckon.
As for - I suppose it makes more sense to have it, than to strive for maximal parsimony
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for datetime arithmetic using the
:+clause:and the accompanying
:intervalclause.The idea is that subtraction just gets rewritten by the QP, but I could see an argument for also supporting this in
:-.A further PR could also depreciate
:relative-datetimeor rather turn it into syntax sugar.