-
Notifications
You must be signed in to change notification settings - Fork 4.9k
/
row_level_restrictions_test.clj
592 lines (532 loc) · 31.9 KB
/
row_level_restrictions_test.clj
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
(ns metabase-enterprise.sandbox.query-processor.middleware.row-level-restrictions-test
(:require [clojure
[string :as str]
[test :refer :all]]
[clojure.core.async :as a]
[honeysql.core :as hsql]
[metabase
[driver :as driver]
[models :refer [Card Collection Field Table]]
[query-processor :as qp]
[test :as mt]
[util :as u]]
[metabase-enterprise.sandbox.query-processor.middleware.row-level-restrictions :as row-level-restrictions]
[metabase-enterprise.sandbox.test-util :as mt.tu]
[metabase.api.common :as api]
[metabase.driver.sql.query-processor :as sql.qp]
[metabase.mbql
[normalize :as normalize]
[util :as mbql.u]]
[metabase.models
[permissions :as perms]
[permissions-group :as perms-group]]
[metabase.query-processor.middleware.cache-test :as cache-test]
[metabase.query-processor.util :as qputil]
[metabase.test.data.env :as tx.env]
[metabase.test.util :as tu]
[metabase.util.honeysql-extensions :as hx]))
;;; +----------------------------------------------------------------------------------------------------------------+
;;; | SHARED GTAP DEFINITIONS & HELPER FNS |
;;; +----------------------------------------------------------------------------------------------------------------+
(defn- identifier
([table-key]
(mt/with-everything-store
(sql.qp/->honeysql (or driver/*driver* :h2) (Table (mt/id table-key)))))
([table-key field-key]
(mt/with-everything-store
(sql.qp/->honeysql (or driver/*driver* :h2) (Field (mt/id table-key field-key))))))
(defn- venues-category-mbql-gtap-def []
{:query (mt/mbql-query venues)
:remappings {:cat ["variable" [:field-id (mt/id :venues :category_id)]]}})
(defn- venues-price-mbql-gtap-def []
{:query (mt/mbql-query venues)
:remappings {:price ["variable" [:field-id (mt/id :venues :price)]]}})
(defn- checkins-user-mbql-gtap-def []
{:query (mt/mbql-query checkins {:filter [:> $date "2014-01-01"]})
:remappings {:user ["variable" [:field-id (mt/id :checkins :user_id)]]}})
(defn- format-honeysql [honeysql]
(let [honeysql (cond-> honeysql
(= driver/*driver* :sqlserver)
(assoc :modifiers ["TOP 1000"])
;; SparkSQL has to have an alias source table (or at least our driver is written as if it has to
;; have one.) HACK
(= driver/*driver* :sparksql)
(update :from (fn [[table]]
[[table (sql.qp/->honeysql :sparksql
(hx/identifier :table-alias @(resolve 'metabase.driver.sparksql/source-table-alias)))]])))]
(first (hsql/format honeysql, :quoting (sql.qp/quote-style driver/*driver*), :allow-dashed-names? true))))
(defn- venues-category-native-gtap-def []
(driver/with-driver (or driver/*driver* :h2)
(assert (driver/supports? driver/*driver* :native-parameters))
{:query (mt/native-query
{:query
(format-honeysql
{:select [:*]
:from [(identifier :venues)]
:where [:= (identifier :venues :category_id) (hsql/raw "{{cat}}")]
:order-by [(identifier :venues :id)]})
:template_tags
{:cat {:name "cat" :display_name "cat" :type "number" :required true}}})
:remappings {:cat ["variable" ["template-tag" "cat"]]}}))
(defn- parameterized-sql-with-join-gtap-def []
(driver/with-driver (or driver/*driver* :h2)
(assert (driver/supports? driver/*driver* :native-parameters))
{:query (mt/native-query
{:query
(format-honeysql
{:select [(identifier :checkins :id)
(identifier :checkins :user_id)
(identifier :venues :name)
(identifier :venues :category_id)]
:from [(identifier :checkins)]
:left-join [(identifier :venues)
[:= (identifier :checkins :venue_id) (identifier :venues :id)]]
:where [:= (identifier :checkins :user_id) (hsql/raw "{{user}}")]
:order-by [[(identifier :checkins :id) :asc]]})
:template_tags
{"user" {:name "user"
:display-name "User ID"
:type :number
:required true}}})
:remappings {:user ["variable" ["template-tag" "user"]]}}))
(defn- venue-names-native-gtap-def []
{:query (mt/native-query
{:query
(format-honeysql
{:select [(identifier :venues :name)]
:from [(identifier :venues)]
:order-by [(identifier :venues :id)]})})})
(defn- run-venues-count-query []
(mt/format-rows-by [int]
(mt/rows
(mt/run-mbql-query venues {:aggregation [[:count]]}))))
(defn- run-checkins-count-broken-out-by-price-query []
(mt/format-rows-by [#(some-> % int) int]
(mt/rows
(mt/run-mbql-query checkins
{:aggregation [[:count]]
:order-by [[:asc $venue_id->venues.price]]
:breakout [$venue_id->venues.price]}))))
;;; +----------------------------------------------------------------------------------------------------------------+
;;; | MIDDLEWARE TESTS |
;;; +----------------------------------------------------------------------------------------------------------------+
(deftest all-table-ids-test
(testing (str "make sure that `all-table-ids` can properly find all Tables in the query, even in cases where a map "
"has a `:source-table` and some of its children also have a `:source-table`"))
(is (= (mt/$ids nil
#{$$checkins $$venues $$users $$categories})
(#'row-level-restrictions/all-table-ids
(mt/mbql-query nil
{:source-table $$checkins
:joins [{:source-table $$venues}
{:source-query {:source-table $$users
:joins [{:source-table $$categories}]}}]})))))
(defn- remove-metadata [m]
(mbql.u/replace m
(_ :guard (every-pred map? :source-metadata))
(remove-metadata (dissoc &match :source-metadata))))
(defn- apply-row-level-permissions [query]
(-> (mt/with-everything-store
(mt/test-qp-middleware row-level-restrictions/apply-row-level-permissions (normalize/normalize query)))
:pre
remove-metadata))
(deftest middleware-test
(testing "Make sure the middleware does the correct transformation given the GTAPs we have"
(mt/with-gtaps {:gtaps {:checkins (checkins-user-mbql-gtap-def)
:venues (dissoc (venues-price-mbql-gtap-def) :query)}
:attributes {"user" 5, "price" 1}}
(testing "Should add a filter for attributes-only GTAP"
(is (= (mt/query checkins
{:type :query
:query {:source-query {:source-table $$checkins
:fields [$id !default.$date $user_id $venue_id]
:filter [:and
[:> $date [:absolute-datetime #t "2014-01-01T00:00Z[UTC]" :default]]
[:=
$user_id
[:value 5 {:base_type :type/Integer
:special_type :type/FK
:database_type "INTEGER"
:name "USER_ID"}]]]
:gtap? true}
:joins [{:source-query
{:source-table $$venues
:fields [$venues.id $venues.name $venues.category_id
$venues.latitude $venues.longitude $venues.price]
:filter [:=
$venues.price
[:value 1 {:base_type :type/Integer
:special_type :type/Category
:database_type "INTEGER"
:name "PRICE"}]]
:gtap? true}
:alias "v"
:strategy :left-join
:condition [:= $venue_id &v.venues.id]}]
:aggregation [[:count]]}
:gtap-perms #{(perms/table-query-path (Table (mt/id :venues)))
(perms/table-query-path (Table (mt/id :checkins)))}})
(apply-row-level-permissions
(mt/mbql-query checkins
{:aggregation [[:count]]
:joins [{:source-table $$venues
:alias "v"
:strategy :left-join
:condition [:= $venue_id &v.venues.id]}]}))))))
(testing "Should substitute appropriate value in native query"
(mt.tu/with-gtaps {:gtaps {:venues (venues-category-native-gtap-def)}
:attributes {"cat" 50}}
(is (= (mt/query nil
{:database (mt/id)
:type :query
:query {:aggregation [[:count]]
:source-query {:native (str "SELECT * FROM \"PUBLIC\".\"VENUES\" "
"WHERE \"PUBLIC\".\"VENUES\".\"CATEGORY_ID\" = 50 "
"ORDER BY \"PUBLIC\".\"VENUES\".\"ID\"")
:params []}}
:gtap-perms #{(perms/adhoc-native-query-path (mt/id))}})
(apply-row-level-permissions
(mt/mbql-query venues
{:aggregation [[:count]]}))))))))
;;; +----------------------------------------------------------------------------------------------------------------+
;;; | END-TO-END TESTS |
;;; +----------------------------------------------------------------------------------------------------------------+
(deftest e2e-test
(mt/test-drivers (mt/normal-drivers-with-feature :nested-queries)
(testing "When querying with full permissions, no changes should be made"
(mt/with-gtaps {:gtaps {:venues (venues-category-mbql-gtap-def)}
:attributes {"cat" 50}}
(perms/grant-permissions! &group (perms/table-query-path (Table (mt/id :venues))))
(is (= [[100]]
(run-venues-count-query)))))
(testing (str "Basic test around querying a table by a user with segmented only permissions and a GTAP question that "
"is a native query")
(mt/with-gtaps {:gtaps {:venues (venues-category-native-gtap-def)}
:attributes {"cat" 50}}
(is (= [[10]]
(run-venues-count-query)))))
(testing (str "Basic test around querying a table by a user with segmented only permissions and a GTAP question that "
"is MBQL")
(mt/with-gtaps {:gtaps {:venues (venues-category-mbql-gtap-def)}
:attributes {"cat" 50}}
(is (= [[10]]
(run-venues-count-query)))))
(testing (str "When processing a query that requires a user attribute and that user attribute isn't there, throw an "
"exception letting the user know it's missing")
(is (thrown-with-msg?
clojure.lang.ExceptionInfo
#"Query requires user attribute `cat`"
(mt/with-gtaps {:gtaps {:venues (venues-category-mbql-gtap-def)}
:attributes {"something_random" 50}}
(mt/run-mbql-query venues {:aggregation [[:count]]})))))
(testing "Another basic test, same as above, but with a numeric string that needs to be coerced"
(mt/with-gtaps {:gtaps {:venues (venues-category-mbql-gtap-def)}
:attributes {"cat" "50"}}
(is (= [[10]]
(run-venues-count-query)))))
(testing "Another basic test, this one uses a stringified float for the login attribute"
(mt/with-gtaps {:gtaps {:venues {:query (mt/mbql-query venues)
:remappings {:cat ["variable" [:field-id (mt/id :venues :latitude)]]}}}
:attributes {"cat" "34.1018"}}
(is (= [[3]]
(run-venues-count-query)))))
(testing "Tests that users can have a different parameter name in their query than they have in their user attributes"
(mt/with-gtaps {:gtaps {:venues {:query (:query (venues-category-native-gtap-def))
:remappings {:something.different ["variable" ["template-tag" "cat"]]}}}
:attributes {"something.different" 50}}
(is (= [[10]]
(run-venues-count-query)))))
(testing "Make sure that you can still use a SQL-based GTAP without needing to have SQL read perms for the Database"
(is (= [["Red Medicine"] ["Stout Burgers & Beers"]]
(mt/rows
(mt/with-gtaps {:gtaps {:venues (venue-names-native-gtap-def)}}
(mt/run-mbql-query venues {:limit 2}))))))
(testing (str "When no card_id is included in the GTAP, should default to a query against the table, with the GTAP "
"criteria applied")
(mt/with-gtaps {:gtaps {:venues (dissoc (venues-category-mbql-gtap-def) :query)}
:attributes {"cat" 50}}
(is (= [[10]]
(run-venues-count-query)))))
(testing "Same test as above but make sure we coerce a numeric string correctly"
(mt/with-gtaps {:gtaps {:venues (dissoc (venues-category-mbql-gtap-def) :query)}
:attributes {"cat" "50"}}
(is (= [[10]]
(run-venues-count-query)))))
(testing "Users with view access to the related collection should bypass segmented permissions"
(mt/with-temp-copy-of-db
(mt/with-temp* [Collection [collection]
Card [card {:collection_id (u/get-id collection)}]]
(mt.tu/with-group [group]
(perms/revoke-permissions! (perms-group/all-users) (mt/id))
(perms/grant-collection-read-permissions! group collection)
(mt/with-test-user :rasta
(is (= 1
(count
(mt/rows
(qp/process-query
{:database (mt/id)
:type :query
:query {:source-table (mt/id :venues)
:limit 1}
:info {:card-id (u/get-id card)
:query-hash (byte-array 0)}}))))))))))
(testing (str "This test isn't covering a row level restrictions feature, but rather checking it it doesn't break "
"querying of a card as a nested query. Part of the row level perms check is looking at the table (or "
"card) to see if row level permissions apply. This was broken when it wasn't expecting a card and "
"only expecting resolved source-tables")
(mt/with-temp Card [card {:dataset_query (mt/mbql-query venues)}]
(mt/with-test-user :rasta
(is (= [[100]]
(mt/format-rows-by [int]
(mt/rows
(qp/process-query
{:database (mt/id)
:type :query
:query {:source-table (format "card__%s" (u/get-id card))
:aggregation [["count"]]}}))))))))))
;; Test that we can follow FKs to related tables and breakout by columns on those related tables. This test has
;; several things wrapped up which are detailed below
(defn- row-level-restrictions-fk-drivers
"Drivers to test row-level restrictions against foreign keys with. Includes BigQuery, which for whatever reason does
not normally have FK tests ran for it."
[]
(cond-> (mt/normal-drivers-with-feature :nested-queries :foreign-keys)
(@tx.env/test-drivers :bigquery) (conj :bigquery)))
;; HACK - Since BigQuery doesn't formally support foreign keys (meaning we can't sync them automatically), FK tests
;; are disabled by default for BigQuery. We really want to test them here! The macros below let us "fake" FK support
;; for BigQuery.
(defn- do-enable-bigquery-fks [f]
(let [supports? driver/supports?]
(with-redefs [driver/supports? (fn [driver feature]
(if (= [driver feature] [:bigquery :foreign-keys])
true
(supports? driver feature)))]
(f))))
(defmacro ^:private enable-bigquery-fks [& body]
`(do-enable-bigquery-fks (fn [] ~@body)))
(defn- do-with-bigquery-fks [f]
(if-not (= driver/*driver* :bigquery)
(f)
(tu/with-temp-vals-in-db Field (mt/id :checkins :user_id) {:fk_target_field_id (mt/id :users :id)
:special_type "type/FK"}
(tu/with-temp-vals-in-db Field (mt/id :checkins :venue_id) {:fk_target_field_id (mt/id :venues :id)
:special_type "type/FK"}
(f)))))
(defmacro ^:private with-bigquery-fks [& body]
`(do-with-bigquery-fks (fn [] ~@body)))
(deftest e2e-fks-test
(mt/test-drivers (row-level-restrictions-fk-drivers)
(enable-bigquery-fks
(testing (str "1 - Creates a GTAP filtering question, looking for any checkins happening on or after 2014\n"
"2 - Apply the `user` attribute, looking for only our user (i.e. `user_id` = 5)\n"
"3 - Checkins are related to Venues, query for checkins, grouping by the Venue's price\n"
"4 - Order by the Venue's price to ensure a predictably ordered response")
(mt/with-gtaps {:gtaps {:checkins (checkins-user-mbql-gtap-def)
:venues nil}
:attributes {"user" 5}}
(with-bigquery-fks
(is (= [[1 10] [2 36] [3 4] [4 5]]
(run-checkins-count-broken-out-by-price-query))))))
(testing (str "Test that we're able to use a GTAP for an FK related table. For this test, the user has segmented "
"permissions on checkins and venues, so we need to apply a GTAP to the original table (checkins) in "
"addition to the related table (venues). This test uses a GTAP question for both tables")
(mt/with-gtaps {:gtaps {:checkins (checkins-user-mbql-gtap-def)
:venues (venues-price-mbql-gtap-def)}
:attributes {"user" 5, "price" 1}}
(with-bigquery-fks
(is (= #{[nil 45] [1 10]}
(set (run-checkins-count-broken-out-by-price-query)))))))
(testing "Test that the FK related table can be a \"default\" GTAP, i.e. a GTAP where the `card_id` is nil"
(mt/with-gtaps {:gtaps {:checkins (checkins-user-mbql-gtap-def)
:venues (dissoc (venues-price-mbql-gtap-def) :query)}
:attributes {"user" 5, "price" 1}}
(with-bigquery-fks
(is (= #{[nil 45] [1 10]}
(set (run-checkins-count-broken-out-by-price-query)))))))
(testing (str "Test that we have multiple FK related, segmented tables. This test has checkins with a GTAP "
"question with venues and users having the default GTAP and segmented permissions")
(mt/with-gtaps {:gtaps {:checkins (checkins-user-mbql-gtap-def)
:venues (dissoc (venues-price-mbql-gtap-def) :query)
:users {:remappings {:user ["variable" [:field-id (mt/id :users :id)]]}}}
:attributes {"user" 5, "price" 1}}
(with-bigquery-fks
(is (= #{[nil "Quentin Sören" 45] [1 "Quentin Sören" 10]}
(set
(mt/format-rows-by [#(when % (int %)) str int]
(mt/rows
(mt/run-mbql-query checkins
{:aggregation [[:count]]
:order-by [[:asc $venue_id->venues.price]]
:breakout [$venue_id->venues.price $user_id->users.name]}))))))))))))
(defn- run-query-returning-remark [run-query-fn]
(let [remark (atom nil)
orig qputil/query->remark]
(with-redefs [qputil/query->remark (fn [driver outer-query]
(u/prog1 (orig driver outer-query)
(reset! remark <>)))]
(let [results (run-query-fn)]
(or (some-> @remark (str/replace #"queryHash: \w+" "queryHash: <hash>"))
(println "NO REMARK FOUND:\n" (u/pprint-to-str 'red results))
(throw (ex-info "No remark found!" {:results results})))))))
(deftest remark-test
(testing "make sure GTAP queries still include ID of user who ran them in the remark"
(mt/with-gtaps {:gtaps {:venues (venues-category-mbql-gtap-def)}
:attributes {"cat" 50}}
(is (= (format "Metabase:: userID: %d queryType: MBQL queryHash: <hash>" (mt/user->id :rasta))
(run-query-returning-remark
(fn []
(mt/user-http-request :rasta :post "dataset" (mt/mbql-query venues {:aggregation [[:count]]})))))))))
(deftest breakouts-test
(mt/test-drivers (row-level-restrictions-fk-drivers)
(testing "Make sure that if a GTAP is in effect we can still do stuff like breakouts (#229)"
(mt/with-gtaps {:gtaps {:venues (venues-category-native-gtap-def)}
:attributes {"cat" 50}}
(is (= [[1 6] [2 4]]
(mt/format-rows-by [int int]
(mt/rows
(mt/run-mbql-query venues
{:aggregation [[:count]]
:breakout [$price]})))))))))
(deftest sql-with-join-test
(mt/test-drivers (row-level-restrictions-fk-drivers)
(testing (str "If we use a parameterized SQL GTAP that joins a Table the user doesn't have access to, does it "
"still work? (EE #230) If we pass the query in directly without anything that would require nesting "
"it, it should work")
(is (= [[2 1 "Bludso's BBQ" 5]
[72 1 "Red Medicine" 4]]
(mt/format-rows-by [int int identity int]
(mt/rows
(mt/with-gtaps {:gtaps {:checkins (parameterized-sql-with-join-gtap-def)}
:attributes {"user" 1}}
(mt/run-mbql-query checkins
{:limit 2})))))))
(testing (str "#230: If we modify the query in a way that would cause the original to get nested as a source query, "
"do things work?")
(is (= [[5 69]]
(mt/format-rows-by [int int]
(mt/rows
(mt/with-gtaps {:gtaps {:checkins (parameterized-sql-with-join-gtap-def)}
:attributes {"user" 5}}
(mt/run-mbql-query checkins
{:aggregation [[:count]]
:breakout [$user_id]})))))))))
(deftest correct-metadata-test
(testing (str "We should return the same metadata as the original Table when running a query against a sandboxed "
"Table (#390)\n")
(let [cols (fn []
(mt/cols
(mt/run-mbql-query venues
{:order-by [[:asc $id]]
:limit 2})))
original-cols (cols)
;; `with-gtaps` copies the test DB so this function will update the IDs in `original-cols` so they'll match
;; up with the current copy
expected-cols (fn []
(for [col original-cols
:let [id (mt/id :venues (keyword (str/lower-case (:name col))))]]
(assoc col
:id id
:table_id (mt/id :venues)
:field_ref [:field-id id])))]
(testing "A query with a simple attributes-based sandbox should have the same metadata"
(mt/with-gtaps {:gtaps {:venues (dissoc (venues-category-mbql-gtap-def) :query)}
:attributes {"cat" 50}}
(is (= (expected-cols)
(cols)))))
(testing "A query with an equivalent MBQL query sandbox should have the same metadata"
(mt/with-gtaps {:gtaps {:venues (venues-category-mbql-gtap-def)}
:attributes {"cat" 50}}
(is (= (expected-cols)
(cols)))))
(testing "A query with an equivalent native query sandbox should have the same metadata"
(mt/with-gtaps {:gtaps {:venues {:query (mt/native-query
{:query
(str "SELECT ID, NAME, CATEGORY_ID, LATITUDE, LONGITUDE, PRICE "
"FROM VENUES "
"WHERE CATEGORY_ID = {{cat}}")
:template_tags
{:cat {:name "cat" :display_name "cat" :type "number" :required true}}})
:remappings {:cat ["variable" ["template-tag" "cat"]]}}}
:attributes {"cat" 50}}
(is (= (expected-cols)
(cols)))))
(testing (str "If columns are added/removed/reordered we should still merge in metadata for the columns we're "
"able to match from the original Table")
(mt/with-gtaps {:gtaps {:venues {:query (mt/native-query
{:query
(str "SELECT NAME, ID, LONGITUDE, PRICE, 1 AS ONE "
"FROM VENUES "
"WHERE CATEGORY_ID = {{cat}}")
:template_tags
{:cat {:name "cat" :display_name "cat" :type "number" :required true}}})
:remappings {:cat ["variable" ["template-tag" "cat"]]}}}
:attributes {"cat" 50}}
(let [[id-col name-col _ _ longitude-col price-col] (expected-cols)
one-col {:name "ONE"
:display_name "ONE"
:base_type :type/Integer
:source :fields
:field_ref [:field-literal "ONE" :type/Integer]}]
(is (= [name-col id-col longitude-col price-col one-col]
(cols)))))))))
(deftest sandboxing-sql-with-joins-test
(testing "Should be able to use a Saved Question with no source Metadata as a GTAP (#525)"
(mt/with-gtaps (mt/$ids
{:gtaps {:venues {:query (mt/native-query
{:query (str "SELECT DISTINCT VENUES.* "
"FROM VENUES "
"LEFT JOIN CHECKINS"
" ON CHECKINS.VENUE_ID = VENUES.ID "
"WHERE CHECKINS.USER_ID IN ({{sandbox}})")
:template-tags {"sandbox"
{:name "sandbox"
:display-name "Sandbox"
:type :text}}})
:remappings {"user_id" [:variable [:template-tag "sandbox"]]}}
:checkins {:remappings {"user_id" [:dimension $checkins.user_id]}}}
:attributes {"user_id" 1}})
(is (= [[2 "2014-09-18T00:00:00Z" 1 31 31 "Bludso's BBQ" 5 33.8894 -118.207 2]
[72 "2015-04-18T00:00:00Z" 1 1 1 "Red Medicine" 4 10.0646 -165.374 3]
[80 "2013-12-27T00:00:00Z" 1 99 99 "Golden Road Brewing" 10 34.1505 -118.274 2]]
(mt/rows
(mt/run-mbql-query checkins
{:joins [{:fields :all
:source-table $$venues
:condition [:= $venue_id [:joined-field "Venue" $venues.id]]
:alias "Venue"}]
:order-by [[:asc $id]]
:limit 3})))))))
(deftest dont-cache-sandboxes-test
(cache-test/with-mock-cache [save-chan]
(mt/with-gtaps {:gtaps {:venues (venues-category-mbql-gtap-def)}
:attributes {"cat" 50}}
(letfn [(run-query []
(qp/process-query (assoc (mt/mbql-query venues {:aggregation [[:count]]})
:cache-ttl 100)))]
(testing "Run the query, should not be cached"
(let [result (run-query)]
(is (= nil
(:cached result)))
(is (= [[10]]
(mt/rows result)))))
(testing "Cache entry should be saved within 5 seconds"
(let [[_ chan] (a/alts!! [save-chan (a/timeout 5000)])]
(is (= save-chan
chan))))
(testing "Run it again, should be cached"
(let [result (run-query)]
(is (= true
(:cached result)))
(is (= [[10]]
(mt/rows result)))))
(testing "Run the query with different User attributes, should not get the cached result"
(mt.tu/with-user-attributes :rasta {"cat" 40}
;; re-bind current user so updated attributes come in to effect
(mt/with-test-user :rasta
(is (= {"cat" 40}
(:login_attributes @api/*current-user*)))
(let [result (run-query)]
(is (= nil
(:cached result)))
(is (= [[9]]
(mt/rows result)))))))))))