Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native Query cannot be cancelled #11713

Closed
Usiel opened this issue Jan 14, 2020 · 3 comments
Closed

Native Query cannot be cancelled #11713

Usiel opened this issue Jan 14, 2020 · 3 comments
Labels
Priority:P2 Average run of the mill bug Querying/Native The SQL/native query editor Type:Bug Product defects
Milestone

Comments

@Usiel
Copy link
Contributor

Usiel commented Jan 14, 2020

Describe the bug
Native Query cannot be cancelled

To Reproduce
Steps to reproduce the behavior:

  1. Create a long running native query
  2. Run the query
  3. Click on abort
  4. Nothing happens

Expected behavior
Query should be cancelled

Information about your Metabase Installation:

{
  "browser-info": {
    "language": "en-GB",
    "platform": "Linux x86_64",
    "userAgent": "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.117 Safari/537.36",
    "vendor": "Google Inc."
  },
  "system-info": {
    "java.runtime.name": "OpenJDK Runtime Environment",
    "java.runtime.version": "11.0.5+10",
    "java.vendor": "AdoptOpenJDK",
    "java.vendor.url": "https://adoptopenjdk.net/",
    "java.version": "11.0.5",
    "java.vm.name": "OpenJDK 64-Bit Server VM",
    "java.vm.version": "11.0.5+10",
    "os.name": "Linux",
    "os.version": "4.14.47-56.37.amzn1.x86_64",
    "user.language": "en",
    "user.timezone": "GMT"
  },
  "metabase-info": {
    "databases": [
      "postgres"
    ],
    "hosting-env": "elastic-beanstalk",
    "application-database": "postgres",
    "run-mode": "prod",
    "version": {
      "date": "2020-01-13",
      "tag": "v0.34.1",
      "branch": "release-0.34.x",
      "hash": "265695c"
    },
    "settings": {
      "report-timezone": "Asia/Kuala_Lumpur"
    }
  }
}

Severity
Annoying if one is tweaking a long running query and has to wait until the previous execution finishes.

Additional context
Adding PR in a second. Not quite sure if I'm missing anything to actually cancel the query on database side, but it seems to work similar to non-native queries.

@Usiel Usiel added .Needs Triage Type:Bug Product defects labels Jan 14, 2020
@mazameli mazameli added Querying/Native The SQL/native query editor Priority:P2 Average run of the mill bug and removed .Needs Triage labels Jan 14, 2020
@aejnsn
Copy link

aejnsn commented Jan 15, 2020

It's probably a bit late to offer any further elaboration on this given the above PR. Let's say you run a long-running query, and then change it in such a way that fixes the slow nature of it, then run again with Cmd+Enter. You get the results for your more immediate query, however once the original slow query completes, the slow results replace the results of the immediate query. Should this perhaps be a separate issue or does this fix also encompass that situation as well?

@paulrosenzweig
Copy link
Contributor

@aejnsn I just opened a separate issue for that. Thanks for bringing it up!

@paulrosenzweig
Copy link
Contributor

Fixed by #11714

@paulrosenzweig paulrosenzweig added this to the 0.34.2 milestone Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:P2 Average run of the mill bug Querying/Native The SQL/native query editor Type:Bug Product defects
Projects
None yet
Development

No branches or pull requests

4 participants