Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public Link file format quick selector missing #12406

Closed
flamber opened this issue Apr 27, 2020 · 0 comments · Fixed by #12804
Closed

Public Link file format quick selector missing #12406

flamber opened this issue Apr 27, 2020 · 0 comments · Fixed by #12804
Labels
Embedding/Public Simple public iframe embeds Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Type:Bug Product defects
Milestone

Comments

@flamber
Copy link
Contributor

flamber commented Apr 27, 2020

Describe the bug
When trying to share a question, the Public Link used to have a file format/type quick selector, but it has gone missing since 0.33.5.1

Workaround You can manually add .csv or .xlsx or .json after the public URL

To Reproduce

  1. Enable public sharing via Admin > Settings > Public Sharing
  2. Go to a question and click Sharing-icon in bottom-right
  3. Right below the URL of Public Link, it used to list CSV XLSX JSON up until 0.33.4:
    image

Information about your Metabase Installation:
Metabase 0.33.5.1, 0.34.0, 0.35.3

Additional context
It doesn't seem like there's any changes specifically in the area, so it must be another change that has caused this missing: https://github.com/metabase/metabase/blob/master/frontend/src/metabase/public/components/widgets/SharingPane.jsx#L120-L139

Reported in the forum: https://discourse.metabase.com/t/format-quick-selectors-missing-in-public-sharing-as-of-version-0-35/9906

@flamber flamber added Type:Bug Product defects Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Embedding/Public Simple public iframe embeds labels Apr 27, 2020
@flamber flamber added this to the 0.37.0 milestone Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Embedding/Public Simple public iframe embeds Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant