Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make driver/db-start-of-week be per-DB #13496

Open
Tracked by #59
sbelak opened this issue Oct 15, 2020 · 1 comment
Open
Tracked by #59

Make driver/db-start-of-week be per-DB #13496

sbelak opened this issue Oct 15, 2020 · 1 comment

Comments

@sbelak
Copy link
Contributor

sbelak commented Oct 15, 2020

Currently we assume all the DBs using the same driver have the same start of week, which for very international organizations (or ones with a lot of legacy) might not be true.

@kaklakariada
Copy link
Contributor

Please consider implementing this. Currently the API does not allow drivers to read the current setting for the start of the week from the database, see sources at https://github.com/metabase/metabase/blob/master/src/metabase/driver.clj#L741

A user of our Exasol driver got wrong results because of this, see exasol/metabase-driver#59.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants