Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defsetting macro throw an Exception if you try to define a setting that's already defined in a different namespace #15000

Closed
camsaul opened this issue Feb 27, 2021 · 0 comments · Fixed by #15359
Closed

defsetting macro throw an Exception if you try to define a setting that's already defined in a different namespace #15000

camsaul opened this issue Feb 27, 2021 · 0 comments · Fixed by #15359
Assignees
@dpsutton
Labels
.Backend Type:Tech Debt or Refactoring
Milestone
0.39

Comments

@camsaul
Copy link
Member

camsaul commented Feb 27, 2021

It's a bug if two different places try to use the same setting name for two different things. We can catch bugs at compile time using the defsetting macro, so we should
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dpsutton dpsutton

Labels
.Backend Type:Tech Debt or Refactoring
Projects
None yet
Milestone
0.39
Development

Successfully merging a pull request may close this issue.

Throw an error if a setting already exists metabase/metabase
2 participants
@camsaul @dpsutton