Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird UX around setting limited data permissions #15233

Closed
nemanjaglumac opened this issue Mar 18, 2021 · 0 comments · Fixed by #17328
Closed

Weird UX around setting limited data permissions #15233

nemanjaglumac opened this issue Mar 18, 2021 · 0 comments · Fixed by #17328
Assignees
Labels
Administration/Permissions Collection or Data permissions Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Type:UX
Milestone

Comments

@nemanjaglumac
Copy link
Member

Describe the bug
You can get into a weird state where you want to limit the permissions on a database, which then correctly opens tables view for you, but if you navigate back to the database view, the icon still shows "limited access". You can click save after which that icon's gone.

Logs

To Reproduce
Steps to reproduce the behavior:

  1. Go to /admin/permissions/databases
  2. Click on data access for a database
  3. Choose "limited"
  4. It immediately opens tables view (really nice touch and expected behavior)
  5. Don't select any table and don't change permissions
  6. Go back to the database view
  7. See that the icon is still "limited"
  8. See that you can actually save permissions
  9. Click Save
  10. After this, the icon is gone and we're back to the original state

Expected behavior

  • Save button shouldn't be enabled if permissions haven't been changed
  • Limited access icon probably shouldn't show before limited access is given/set

Screenshots

Information about your Metabase Installation:
N/A

Severity
UX/UI. Extremely low.

@flamber flamber added Administration/Permissions Collection or Data permissions Priority:P3 Cosmetic bugs, minor bugs with a clear workaround and removed .Needs Triage Type:Bug Product defects labels Mar 18, 2021
@alxnddr alxnddr self-assigned this Aug 11, 2021
@flamber flamber added this to the 0.41 milestone Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Administration/Permissions Collection or Data permissions Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Type:UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants