Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Expression filter not setting the "Done" button to current state of the formula until onblur #15244

Closed
flamber opened this issue Mar 19, 2021 · 1 comment
Assignees
Labels
Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Notebook Items specific to the Custom/Notebook query builder Type:UX
Milestone

Comments

@flamber
Copy link
Contributor

flamber commented Mar 19, 2021

Describe the bug
The Done-button on Custom Expression can be somewhat difficult to figure out, when it's possible to finish, since it sometimes requires blurring the input before the state gets updated.

To Reproduce

  1. Custom question > Sample Dataset > Products
  2. Filter > Custom Expression - notice the Done-button is enabled by default
    image
  3. Blur the input - now the Done-button is disabled
    image
  4. Type 1=1 in the formula - the Done-button is still disabled. Pressing enter does not make a difference, still disabled. But it's possible to click the disabled button, since it will blur the input and enable the button instantly.
    image

Expected behavior
The Done-button should not be enabled on empty formula.
And perhaps should follow the state of the formula.

Information about your Metabase Installation:
Tested 0.36.8 thru 0.38.2 and master

@flamber flamber added Type:UX Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Notebook Items specific to the Custom/Notebook query builder labels Mar 19, 2021
@howonlee howonlee self-assigned this Mar 19, 2021
@flamber
Copy link
Contributor Author

flamber commented Mar 29, 2021

Fixed by #15293

@flamber flamber closed this as completed Mar 29, 2021
@flamber flamber added this to the 0.39 milestone Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Notebook Items specific to the Custom/Notebook query builder Type:UX
Projects
None yet
Development

No branches or pull requests

2 participants