Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version info and hash missing in 'About Metabase' in master #16045

Closed
rlotun opened this issue May 13, 2021 · 7 comments · Fixed by #16052
Closed

Version info and hash missing in 'About Metabase' in master #16045

rlotun opened this issue May 13, 2021 · 7 comments · Fixed by #16052
Assignees
Labels
Milestone

Comments

@rlotun
Copy link
Contributor

rlotun commented May 13, 2021

Describe the bug
Clicking on Gear Icon -> About Metabase shows an empty version and git hash.

Expected behavior
I expect to see something like "0.40-SNAPSHOT" and a git sha

Screenshots
Screen Shot 2021-05-13 at 10 58 16 AM

Information about your Metabase Installation:

You can get this information by going to Admin -> Troubleshooting.

{
  "browser-info": {
    "language": "en-US",
    "platform": "MacIntel",
    "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/90.0.4430.93 Safari/537.36",
    "vendor": "Google Inc."
  },
  "system-info": {
    "file.encoding": "UTF-8",
    "java.runtime.name": "OpenJDK Runtime Environment",
    "java.runtime.version": "11.0.11+9",
    "java.vendor": "AdoptOpenJDK",
    "java.vendor.url": "https://adoptopenjdk.net/",
    "java.version": "11.0.11",
    "java.vm.name": "OpenJDK 64-Bit Server VM",
    "java.vm.version": "11.0.11+9",
    "os.name": "Linux",
    "os.version": "4.14.225-121.362.amzn1.x86_64",
    "user.language": "en",
    "user.timezone": "GMT"
  },
  "metabase-info": {
    "databases": [
      "mysql",
      "postgres",
      "bigquery",
      "redshift",
      "druid",
      "mongo",
      "googleanalytics",
      "h2"
    ],
    "hosting-env": "unknown",
    "application-database": "postgres",
    "application-database-details": {
      "database": {
        "name": "PostgreSQL",
        "version": "9.6.20"
      },
      "jdbc-driver": {
        "name": "PostgreSQL JDBC Driver",
        "version": "42.2.18"
      }
    },
    "run-mode": "prod",
    "version": {},
    "settings": {
      "report-timezone": "US/Pacific"
    }
  }
}
@flamber
Copy link
Contributor

flamber commented May 13, 2021

Related to #15656 and #15677

@camsaul
Copy link
Member

camsaul commented May 13, 2021

How did you build it? Version info is only present if it's built during the build process. If you just did lein uberjar it might not be there

@dpsutton
Copy link
Contributor

I'm running the ee-uberjar from CI and seeing this:
image

    "version": {
      "date": "2021-05-13",
      "tag": "vUNKNOWN",
      "branch": "master",
      "hash": "b5f9b61"
    },

@flamber
Copy link
Contributor

flamber commented May 13, 2021

This is stats:
image

@rlotun
Copy link
Contributor Author

rlotun commented May 13, 2021

I see it on stats and docker (metabase-head)

@camsaul
Copy link
Member

camsaul commented May 13, 2021

It seems like it's only happening with multi-stage Dockerfile used to build the head images.

I'm guessing maybe the reason this is happening is because the Docker builder image (first stage of ./Dockerfile) doesn't have git installed (?) so it can't generate version info. Although in that case I'd expect it to fail entirely...

@camsaul
Copy link
Member

camsaul commented May 13, 2021

This is a regression introduced with the changes in #15819, on this line: https://github.com/metabase/metabase/blob/master/Dockerfile#L63

We're not running the version step anymore. When we call bin/build uberjar it only runs the uberjar step (bin/build with no args runs everything). This is only on master, not on the release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants