Table view on Permissions shows error on browser refresh

[flamber]

Describe the bug
Table view (not Database view) on Admin > Permissions shows error on browser refresh.

To Reproduce

1. Admin > Permissions > Sample Dataset - do a browser refresh (might need to open a new tab)
   

Something went wrong

    in Connect(PermissionsEditor)
    in div
    in t
    in Connect(t)
    in PermissionsApp
    in t
    in FitViewport
    in DataPermissionsApp
    in Unknown
    in Title[]
    in Unknown
    in UserIsAdmin(Component)
    in Connect(UserIsAdmin(Component))
    in UserIsAuthenticated(Connect(UserIsAdmin(Component)))
    in Connect(UserIsAuthenticated(Connect(UserIsAdmin(Component))))
    in MetabaseIsSetup(Connect(UserIsAuthenticated(Connect(UserIsAdmin(Component)))))
    in Connect(MetabaseIsSetup(Connect(UserIsAuthenticated(Connect(UserIsAdmin(Component))))))
    in BackgroundApplicator
    in Title[BackgroundApplicator]
    in div
    in t
    in ScrollToTop
    in t
    in App
    in Title[App]
    in RouterContext
    in Router
    in t
    in DragDropContextProvider
    in a

Information about your Metabase Installation:
Regression since 0.39.0 - tested 0.38.4 thru 0.39.2 and release-x.39.x (almost 1.39.3)

Severity
Just noticed it while doing other permissions testing.
Does not seem like it causes any problems, but was just really annoying, since I was reloading about 100 times.

[nemanjaglumac]

Annoyingly, I can repro locally but for whatever reason cannot repro in Cypress. No matter how many times I use cy.reload(), it doesn't trigger this error.

[daltojohnso]

i'm unable to repro. if you're still able to can you paste what's in the browser console?

[flamber]

@daltojohnso Try going directly to this URL in a new tab: /admin/permissions/databases/1/schemas/PUBLIC/tables
Browser console:

TypeError: Cannot read property 'tables' of null
    at app-main.bundle.js?d…ee2d64ac75c0a75de:5
    at vendor.bundle.js?df6ee2d…:19
    at vendor.bundle.js?df6ee2d…:19
    at vendor.bundle.js?df6ee2d…:19
    at vendor.bundle.js?df6ee2d…:19
    at Function.mapToProps (app-main.bundle.js?d…ee2d64ac75c0a75de:5)
    at i (vendor.bundle.js?df6…2d64ac75c0a75de:434)
    at vendor.bundle.js?df6…2d64ac75c0a75de:495
    at p (vendor.bundle.js?df6…2d64ac75c0a75de:495)
    at vendor.bundle.js?df6…2d64ac75c0a75de:495
overrideMethod	@	react_devtools_backend.js:2560
ns	@	vendor.bundle.js?df6…2d64ac75c0a75de:487
o.componentDidCatch.n.callback	@	vendor.bundle.js?df6…2d64ac75c0a75de:487
fo	@	vendor.bundle.js?df6…2d64ac75c0a75de:487
ss	@	vendor.bundle.js?df6…2d64ac75c0a75de:487
(anonymous)	@	vendor.bundle.js?df6…2d64ac75c0a75de:487
t.unstable_runWithPriority	@	vendor.bundle.js?df6…2d64ac75c0a75de:495
Wi	@	vendor.bundle.js?df6…2d64ac75c0a75de:487
Mu	@	vendor.bundle.js?df6…2d64ac75c0a75de:487
uu	@	vendor.bundle.js?df6…2d64ac75c0a75de:487
(anonymous)	@	vendor.bundle.js?df6…2d64ac75c0a75de:487
t.unstable_runWithPriority	@	vendor.bundle.js?df6…2d64ac75c0a75de:495
Wi	@	vendor.bundle.js?df6…2d64ac75c0a75de:487
Vi	@	vendor.bundle.js?df6…2d64ac75c0a75de:487
Ui	@	vendor.bundle.js?df6…2d64ac75c0a75de:487
iu	@	vendor.bundle.js?df6…2d64ac75c0a75de:487
enqueueSetState	@	vendor.bundle.js?df6…2d64ac75c0a75de:487
b.setState	@	vendor.bundle.js?df6…2d64ac75c0a75de:448
c.onStateChange	@	vendor.bundle.js?df6…2d64ac75c0a75de:434
notify	@	vendor.bundle.js?df6…2d64ac75c0a75de:495
t.notifyNestedSubs	@	vendor.bundle.js?df6…2d64ac75c0a75de:495
c.onStateChange	@	vendor.bundle.js?df6…2d64ac75c0a75de:434
g	@	vendor.bundle.js?df6…2d64ac75c0a75de:434
dispatch	@	VM142:3856
(anonymous)	@	vendor.bundle.js?df6…2d64ac75c0a75de:440
(anonymous)	@	vendor.bundle.js?df6…2d64ac75c0a75de:116
(anonymous)	@	app-main.bundle.js?d…ee2d64ac75c0a75de:5
dispatch	@	vendor.bundle.js?df6…2d64ac75c0a75de:495
(anonymous)	@	app-main.bundle.js?d…ee2d64ac75c0a75de:5
l	@	vendor.bundle.js?df6ee2d…:98

[daltojohnso]

Thanks, @flamber -- that does the trick