Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error message missing when logging in to a disabled account with Google sign-in #16701

Closed
noahmoss opened this issue Jun 21, 2021 · 0 comments · Fixed by #16689
Closed

Error message missing when logging in to a disabled account with Google sign-in #16701

noahmoss opened this issue Jun 21, 2021 · 0 comments · Fixed by #16689
Assignees
@noahmoss
Labels
Administration/Auth Google Auth, LDAP, pw+email login .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects
Milestone
0.40

Comments

@noahmoss
Copy link
Member

Regression caused by the 400 -> 401 error response change on the backend for login failure. This should be fixed by #16689.
@noahmoss noahmoss added Type:Bug Product defects Administration/Auth Google Auth, LDAP, pw+email login .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. labels Jun 21, 2021
@noahmoss noahmoss mentioned this issue Jun 21, 2021
Merged
@noahmoss noahmoss added this to the 0.40 milestone Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noahmoss noahmoss

Labels
Administration/Auth Google Auth, LDAP, pw+email login .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects
Projects
None yet
Milestone
0.40
Development

Successfully merging a pull request may close this issue.

Restore Google sign-in deactivated account message metabase/metabase
1 participant
@noahmoss