Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revision history does not update until page reload #17910

Closed
daltojohnso opened this issue Sep 15, 2021 · 1 comment · Fixed by #17887 or #22004
Closed

Revision history does not update until page reload #17910

daltojohnso opened this issue Sep 15, 2021 · 1 comment · Fixed by #17887 or #22004
Assignees
Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/GUI Query builder catch-all, including simple mode .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Dashboards .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone

Comments

@daltojohnso
Copy link
Contributor

daltojohnso commented Sep 15, 2021

Describe the bug
When you update a saved question, the change is not reflected in the History timeline because the cache of revision history entities is never cleared.

To Reproduce

  1. Ask a Question > Simple Question > Sample Dataset > People
  2. Save the People table as a new question
  3. Click the name of the saved question ("People" by default) to open the details sidebar
  4. Click on the "History" drawer to see the revision history of the question (since it is a new question, there should only be a single entry)
  5. Add a description to the question and save
  6. Note that a new entry is not added to the History timeline
  7. Refresh the page and return to the History timeline to see a new entry noting the change in description

Expected behavior
A new revision history entry should be immediately visible and not require a refresh after editing a question or dashboard.

Severity
p3

⚠️ See #19466. An e2e test was adapted in that PR, and should be reverted once this issue is fixed.

@daltojohnso daltojohnso self-assigned this Sep 15, 2021
@daltojohnso daltojohnso added Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/GUI Query builder catch-all, including simple mode Reporting/Dashboards .Frontend and removed .Needs Triage labels Sep 15, 2021
@flamber flamber added this to the 0.41 milestone Sep 23, 2021
@gusaiani
Copy link
Contributor

Reopening.

See #19466

@gusaiani gusaiani reopened this Dec 23, 2021
@flamber flamber removed this from the 0.41 milestone Dec 25, 2021
@flamber flamber added the .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. label Dec 25, 2021
@npfitz npfitz self-assigned this Apr 21, 2022
@npfitz npfitz added the .Reproduced Issues reproduced in test (usually Cypress) label Apr 26, 2022
@flamber flamber added this to the 0.43 milestone Apr 26, 2022
This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/GUI Query builder catch-all, including simple mode .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Dashboards .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
4 participants