-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up old static charts #19653
Clean up old static charts #19653
Conversation
1702034
to
48c3e25
Compare
@howonlee can I safely drop these? |
Codecov Report
@@ Coverage Diff @@
## master #19653 +/- ##
=======================================
Coverage 65.31% 65.31%
=======================================
Files 2032 2032
Lines 73231 73231
Branches 8626 8626
=======================================
Hits 47831 47831
Misses 21670 21670
Partials 3730 3730
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't know we could kill this much stuff
48c3e25
to
1deab8c
Compare
@metabase-bot run visual tests |
Notifying subscribers in CODENOTIFY files for diff 08c3fbf...47412fb.
|
@metabase-bot run visual tests |
Cleaning up old static charts which were replaced by
XYChart
that supports multiple series of all types