Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up old static charts #19653

Merged
merged 2 commits into from
Jan 13, 2022
Merged

Clean up old static charts #19653

merged 2 commits into from
Jan 13, 2022

Conversation

alxnddr
Copy link
Member

@alxnddr alxnddr commented Jan 12, 2022

Cleaning up old static charts which were replaced by XYChart that supports multiple series of all types

@alxnddr alxnddr requested a review from howonlee January 12, 2022 23:35
@alxnddr alxnddr self-assigned this Jan 12, 2022
@alxnddr
Copy link
Member Author

alxnddr commented Jan 12, 2022

@howonlee can I safely drop these?

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #19653 (08c3fbf) into master (08c3fbf) will not change coverage.
The diff coverage is n/a.

❗ Current head 08c3fbf differs from pull request most recent head 47412fb. Consider uploading reports for the commit 47412fb to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #19653   +/-   ##
=======================================
  Coverage   65.31%   65.31%           
=======================================
  Files        2032     2032           
  Lines       73231    73231           
  Branches     8626     8626           
=======================================
  Hits        47831    47831           
  Misses      21670    21670           
  Partials     3730     3730           
Flag Coverage Δ
back-end 85.56% <0.00%> (ø)
front-end 44.44% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08c3fbf...47412fb. Read the comment docs.

Copy link
Contributor

@howonlee howonlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't know we could kill this much stuff

@alxnddr
Copy link
Member Author

alxnddr commented Jan 13, 2022

@metabase-bot run visual tests

@alxnddr alxnddr marked this pull request as ready for review January 13, 2022 22:20
@github-actions
Copy link

github-actions bot commented Jan 13, 2022

Notifying subscribers in CODENOTIFY files for diff 08c3fbf...47412fb.

Notify File(s)
@ranquild frontend/src/metabase/static-viz/components/CategoricalAreaChart/CategoricalAreaChart.jsx
frontend/src/metabase/static-viz/components/CategoricalAreaChart/index.js
frontend/src/metabase/static-viz/components/CategoricalBarChart/CategoricalBarChart.jsx
frontend/src/metabase/static-viz/components/CategoricalBarChart/index.js
frontend/src/metabase/static-viz/components/CategoricalLineChart/CategoricalLineChart.jsx
frontend/src/metabase/static-viz/components/CategoricalLineChart/index.js
frontend/src/metabase/static-viz/components/TimeSeriesAreaChart/TimeSeriesAreaChart.jsx
frontend/src/metabase/static-viz/components/TimeSeriesAreaChart/index.js
frontend/src/metabase/static-viz/components/TimeSeriesBarChart/TimeSeriesBarChart.jsx
frontend/src/metabase/static-viz/components/TimeSeriesBarChart/index.js
frontend/src/metabase/static-viz/components/TimeSeriesLineChart/TimeSeriesLineChart.jsx
frontend/src/metabase/static-viz/components/TimeSeriesLineChart/index.js
frontend/src/metabase/static-viz/containers/StaticChart/StaticChart.jsx
frontend/src/metabase/static-viz/containers/StaticChart/StaticChart.unit.spec.js

@alxnddr
Copy link
Member Author

alxnddr commented Jan 13, 2022

@metabase-bot run visual tests

@alxnddr alxnddr merged commit 5fdeed9 into master Jan 13, 2022
@alxnddr alxnddr deleted the clean-up-old-static-charts branch January 13, 2022 23:48
alxnddr added a commit that referenced this pull request Jan 14, 2022
alxnddr added a commit that referenced this pull request Jan 14, 2022
howonlee added a commit that referenced this pull request Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants