Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard shows scrollbar in fullscreen #21992

Closed
flamber opened this issue Apr 25, 2022 · 0 comments · Fixed by #22058
Closed

Dashboard shows scrollbar in fullscreen #21992

flamber opened this issue Apr 25, 2022 · 0 comments · Fixed by #22058
Assignees
@npfitz
Labels
.CSS Difficulty:Easy .Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Dashboards Type:Bug Product defects
Milestone
0.43

Comments

@flamber
Copy link
Contributor

flamber commented Apr 25, 2022

Describe the bug
Dashboard shows scrollbar in fullscreen - looks like it's caused by the navbar calculation calc(-52px + 100vh), which shouldn't be used when there isn't a navbar.
Regression since 0.43.0-rc1

To Reproduce

  1. Go to dashboard and click "Enter fullscreen"
    image

Information about your Metabase Installation:
Tested 0.42.4 thru 0.43.0-rc1 and master 485b83e
@flamber flamber added Type:Bug Product defects .CSS Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Reporting/Dashboards Difficulty:Easy .Frontend .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. labels Apr 25, 2022
@npfitz npfitz self-assigned this Apr 25, 2022
This was referenced Apr 25, 2022
Merged
Merged
@flamber flamber added this to the 0.43 milestone Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@npfitz npfitz

Labels
.CSS Difficulty:Easy .Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Dashboards Type:Bug Product defects
Projects
None yet
Milestone
0.43
Development

Successfully merging a pull request may close this issue.

Adding fullscreen check to hasNavBar metabase/metabase
2 participants
@npfitz @flamber