Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pulses to be temporarily turned off #2219

Closed
tlrobinson opened this issue Mar 23, 2016 · 6 comments
Closed

Allow pulses to be temporarily turned off #2219

tlrobinson opened this issue Mar 23, 2016 · 6 comments
Assignees
Labels
Reporting/Pulses Now called Subscriptions
Milestone

Comments

@tlrobinson
Copy link
Contributor

We should give the user a way to temporarily turn off a pulse without deleting it. Simplest way with no UI changes would be to relax the >= 1 pulse channel requirement for existing pulses.

@tlrobinson tlrobinson added Proposal Reporting/Pulses Now called Subscriptions labels Mar 23, 2016
@tlrobinson
Copy link
Contributor Author

For anyone currently running into this, a workaround is to use the email channel with no email addresses.

@mazameli
Copy link
Contributor

Also, in this new world where you can turn off your last channel, we shouldn't delete the list of email recipients. Currently, if you turn off your email channel, and then turn it back on, you have to reenter all the recipients, which majorly blows 😤, and is an anti-pattern for the use case where you're just trying to turn it off temporarily with the intention of turning it back on and having the same recipient list.

@kdoh
Copy link
Member

kdoh commented Mar 23, 2016

Ick yeah this is an unfortunate oversight on my part. Ideally we'd save the active status on a channel as a boolean separate from the recipients so you can update one without affecting the other.

@salsakran
Copy link
Contributor

Is there anything that needs to be discussed or are we ready to just go with @tlrobinson's suggested change in the original description?

@kdoh
Copy link
Member

kdoh commented Mar 24, 2016

Not as far as I'm concerned

@mazameli
Copy link
Contributor

Ship it 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Reporting/Pulses Now called Subscriptions
Projects
None yet
Development

No branches or pull requests

5 participants