-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow pulses to be temporarily turned off #2219
Comments
For anyone currently running into this, a workaround is to use the email channel with no email addresses. |
Also, in this new world where you can turn off your last channel, we shouldn't delete the list of email recipients. Currently, if you turn off your email channel, and then turn it back on, you have to reenter all the recipients, which majorly blows 😤, and is an anti-pattern for the use case where you're just trying to turn it off temporarily with the intention of turning it back on and having the same recipient list. |
Ick yeah this is an unfortunate oversight on my part. Ideally we'd save the active status on a channel as a boolean separate from the recipients so you can update one without affecting the other. |
Is there anything that needs to be discussed or are we ready to just go with @tlrobinson's suggested change in the original description? |
Not as far as I'm concerned |
Ship it 🚀 |
We should give the user a way to temporarily turn off a pulse without deleting it. Simplest way with no UI changes would be to relax the >= 1 pulse channel requirement for existing pulses.
The text was updated successfully, but these errors were encountered: