Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click Behavior not redirecting in some cases #22702

Closed
ehsanm94 opened this issue May 13, 2022 · 1 comment · Fixed by #23237
Closed

Click Behavior not redirecting in some cases #22702

ehsanm94 opened this issue May 13, 2022 · 1 comment · Fixed by #23237
Assignees
Labels
.Frontend Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Dashboards/Click Behavior .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone

Comments

@ehsanm94
Copy link

Describe the bug
Setting a custom URL as click behavior which points to the current dashboard not works.
dashboard url: my.mb.ltd/dashboard/n?k=v
custom URL (click behavior): my.mb.ltd/dashboard/n?k={{k}}

Logs
nothing

To Reproduce
Steps to reproduce the behavior:

  1. Create a new dashboard (D1) or open an existing one.
  2. Add a question to it (Q1).
  3. Add a filter (F1) and connect it to Q1.
  4. Set a custom URL click behavior for Q1 which links to D1 and alter the some filters like F1.
  5. Click behavior wont work and the page (D1) wont reload.

Expected behavior
The dashboard should reload with new query parameters provided by custom URL. (It worked fine in metabase v0.37.4 which recently I upgraded it to v0.43.0)

Information about your Metabase Installation:

  • Browser and the version: Chrome 101, Firefox 100
  • Operating system: Fedora 29
  • Databases: MongoDB
  • Metabase version: v0.43.0
  • Metabase hosting environment: Docker
  • Metabase internal database: Postgres
@ehsanm94 ehsanm94 added .Needs Triage Type:Bug Product defects labels May 13, 2022
@ehsanm94 ehsanm94 changed the title click behavior, set custom URL to same dashboard not works in v0.43.0 Click behavior, set custom URL to same dashboard not works in v0.43.0 May 13, 2022
@flamber flamber added Priority:P2 Average run of the mill bug .Frontend .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Dashboards/Click Behavior and removed .Needs Triage labels May 13, 2022
@flamber
Copy link
Contributor

flamber commented May 13, 2022

Regression since 0.43.0 - my guess is that it's caused by #20568

You can see that the URL changes for a split-second, when clicking step5, but is reverted instantly, because it is not a full URL redirect, but just a history push - similar to #7133 (comment)

@alxnddr alxnddr self-assigned this Jun 6, 2022
@flamber flamber added this to the 0.43.3 milestone Jun 9, 2022
@flamber flamber changed the title Click behavior, set custom URL to same dashboard not works in v0.43.0 Click Behavior not redirecting in some cases Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend Priority:P2 Average run of the mill bug .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Dashboards/Click Behavior .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants