Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Expression field is not respecting the modal size #23223

Closed
diogormendes opened this issue Jun 8, 2022 · 1 comment · Fixed by #23280
Closed

Custom Expression field is not respecting the modal size #23223

diogormendes opened this issue Jun 8, 2022 · 1 comment · Fixed by #23280
Assignees
@alxnddr
Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Notebook/Custom Expression .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects
Milestone
0.43.3

Comments

@diogormendes
Copy link
Contributor

diogormendes commented Jun 8, 2022 •
edited

Describe the bug
The input field is bigger than the modal

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'new'
  2. Click on 'question'
  3. Choose a DB
  4. Click on 'Pick the metric you want to see' over 'Summarize'
  5. Click on 'Custom Expression'
  6. See the error

Expected behavior
The input field should be within the modal borders

Screenshots

Screen.Recording.2022-06-08.at.09.30.01.mov

The error is reproducible on:

  • Master branch '8eec37'
  • x.43.2
@flamber flamber added Priority:P3 Cosmetic bugs, minor bugs with a clear workaround .Frontend .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Querying/Notebook/Custom Expression and removed .Needs Triage labels Jun 8, 2022
@flamber
Copy link
Contributor

flamber commented Jun 8, 2022

Regression since 0.43.2 - likely caused by #23045

@alxnddr alxnddr self-assigned this Jun 10, 2022
@alxnddr alxnddr mentioned this issue Jun 10, 2022
Merged
@flamber flamber added this to the 0.43.3 milestone Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alxnddr alxnddr

Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Notebook/Custom Expression .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Type:Bug Product defects
Projects
None yet
Milestone
0.43.3
Development

Successfully merging a pull request may close this issue.

fix aggregation custom expression input width metabase/metabase
3 participants
@flamber @alxnddr @diogormendes