Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Exclude" filter on dashboard doesn't show any value in filter widget when nothing is excluded #24235

Closed
noahmoss opened this issue Jul 22, 2022 · 3 comments · Fixed by #24863
Assignees
Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Dashboards .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Milestone

Comments

@noahmoss
Copy link
Member

noahmoss commented Jul 22, 2022

Describe the bug
If you have a date/all-options filter on a dashboard, and you set it to "Exclude" but don't exclude anything, the filter widget is blank.

To Reproduce
Steps to reproduce the behavior:

  1. Create a dashboard with a question with a temporal field, or a markdown card with a variable
  2. Add a filter to the dashboard with the date/all-options type
  3. Connect the filter to the question/card and save the dashboard
  4. Click on the filter widget > click "Excludes..." > click any granularity
  5. Click "Update filter" without unchecking anything
  6. Filter widget will be blank

Expected behavior
Filter widget should not be blank. Maybe it should say Exclude nothing or similar.

Screenshots

Screen.Recording.2022-07-22.at.3.17.18.PM.mov

Information about your Metabase Installation:
Current master

@noahmoss noahmoss added Type:Bug Product defects .Needs Triage labels Jul 22, 2022
@flamber flamber added Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Reporting/Dashboards Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. .Frontend and removed .Needs Triage labels Jul 23, 2022
@KlingerMatheus
Copy link

@noahmoss do you think No selections would be good?

Demo : https://www.loom.com/share/3594e075bc14447085179f6e806bd581

@noahmoss
Copy link
Member Author

@KlingerMatheus I just discussed with one of our PMs. We should actually show the empty filter in this case, i.e.:

image

@KlingerMatheus
Copy link

@KlingerMatheus I just discussed with one of our PMs. We should actually show the empty filter in this case, i.e.:

image

Got it! I thought about it too, i will provide the change.

@ranquild ranquild self-assigned this Aug 15, 2022
@ranquild ranquild added the .Reproduced Issues reproduced in test (usually Cypress) label Aug 19, 2022
@flamber flamber added this to the 0.44.2 milestone Aug 19, 2022
@deploysentinel deploysentinel bot mentioned this issue Jun 12, 2023
1 task
This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/Parameters & Variables Filter widgets, field filters, variables etc. .Regression Bugs that were previously fixed and/or bugs unintentionally shipped with new features. Reporting/Dashboards .Reproduced Issues reproduced in test (usually Cypress) Type:Bug Product defects
Projects
None yet
4 participants