-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Exclude" filter on dashboard doesn't show any value in filter widget when nothing is excluded #24235
Labels
.Frontend
Priority:P3
Cosmetic bugs, minor bugs with a clear workaround
Querying/Parameters & Variables
Filter widgets, field filters, variables etc.
.Regression
Bugs that were previously fixed and/or bugs unintentionally shipped with new features.
Reporting/Dashboards
.Reproduced
Issues reproduced in test (usually Cypress)
Type:Bug
Product defects
Milestone
Comments
flamber
added
Priority:P3
Cosmetic bugs, minor bugs with a clear workaround
Reporting/Dashboards
Querying/Parameters & Variables
Filter widgets, field filters, variables etc.
.Regression
Bugs that were previously fixed and/or bugs unintentionally shipped with new features.
.Frontend
and removed
.Needs Triage
labels
Jul 23, 2022
@noahmoss do you think Demo : https://www.loom.com/share/3594e075bc14447085179f6e806bd581 |
@KlingerMatheus I just discussed with one of our PMs. We should actually show the empty filter in this case, i.e.: |
Got it! I thought about it too, i will provide the change. |
4 tasks
1 task
This was referenced May 26, 2023
This was referenced Jan 11, 2024
This was referenced Feb 5, 2024
Merged
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
.Frontend
Priority:P3
Cosmetic bugs, minor bugs with a clear workaround
Querying/Parameters & Variables
Filter widgets, field filters, variables etc.
.Regression
Bugs that were previously fixed and/or bugs unintentionally shipped with new features.
Reporting/Dashboards
.Reproduced
Issues reproduced in test (usually Cypress)
Type:Bug
Product defects
Describe the bug
If you have a
date/all-options
filter on a dashboard, and you set it to "Exclude" but don't exclude anything, the filter widget is blank.To Reproduce
Steps to reproduce the behavior:
date/all-options
typeExpected behavior
Filter widget should not be blank. Maybe it should say
Exclude nothing
or similar.Screenshots
Screen.Recording.2022-07-22.at.3.17.18.PM.mov
Information about your Metabase Installation:
Current master
The text was updated successfully, but these errors were encountered: