Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer a new full-app embedding url param for logo #27293

Closed
cdeweyx opened this issue Dec 16, 2022 · 2 comments
Closed

Offer a new full-app embedding url param for logo #27293

cdeweyx opened this issue Dec 16, 2022 · 2 comments
Assignees
Labels
Administration/Whitelabel Enterprise white labelling Embedding/Interactive Interactive Embedding, previously known as Full app embedding Type:New Feature
Milestone

Comments

@cdeweyx
Copy link

cdeweyx commented Dec 16, 2022

Context

We offer several several url parameters for customers in full-app embedding to configure how their Metabase instance looks in the embedded iFrame. We recently made the top_nav default visible and added breadcrumbs as an option in #26977.

With this new behavior, there's a new twist of "I want breadcrumbs so that my users can navigate the instance, but I already show a logo in my app, so having the logo in the top nav as well is duplicative and looks bad." Example below.

Let's offer a new logo sub-param for top_nav that is default on. When it's disabled, breadcrumbs should be scooted over to be left-aligned. Same logic as before if all sub-params are disabled, the whole top-nav is disabled as it serves no purpose.

Image

@cdeweyx cdeweyx added Embedding/ Use this label when unsure which flavor of embedding is impacted .Epic Feature Implementation or Project labels Dec 16, 2022
@bunnymatt
Copy link

We got creative and changed the logo to be the sidebar icon :)

Screen Shot 2022-12-16 at 11 29 45 AM

@cdeweyx cdeweyx removed the .Epic Feature Implementation or Project label Dec 16, 2022
@flamber flamber added Type:New Feature Embedding/Interactive Interactive Embedding, previously known as Full app embedding Administration/Whitelabel Enterprise white labelling and removed Embedding/ Use this label when unsure which flavor of embedding is impacted labels Dec 17, 2022
@brunobergher
Copy link
Contributor

brunobergher commented Dec 23, 2022

Here's the spec we agreed to on Slack.

Param
The parameter is called logo, default true.

States
If logo: true and sidenav: true, it looks like regular Metabase
If logo: true and sidenav: false, just don’t show the sidenav hover icon on the logo.
If logo: false and sidenav: true, we always show the sidenav icon, as in the comment above, with the usual gray color in normal state, brand color on hover.
If logo: false and sidenav: false, the breadcrumbs move all the way to the left.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Administration/Whitelabel Enterprise white labelling Embedding/Interactive Interactive Embedding, previously known as Full app embedding Type:New Feature
Projects
None yet
Development

No branches or pull requests

8 participants