Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeouts not being displayed in dashboard errors #2845

Closed
salsakran opened this issue Jun 28, 2016 · 1 comment
Closed

Timeouts not being displayed in dashboard errors #2845

salsakran opened this issue Jun 28, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@salsakran
Copy link
Contributor

Gateway timeouts errors aren't being shown in dashboard cards

If this is a bug report, please fill in the blanks:

  • I am using the Chrome browser.
  • My computer's OS is Mac OS X.
  • I'm running Metabase on elastic beanstalk.
  • My database is PostgeSQL.
  • My Metabase version is 0.18.1.

screen shot 2016-06-27 at 5 40 14 pm

@salsakran salsakran added this to the 0.19.0 milestone Jun 28, 2016
@lewisl9029 lewisl9029 self-assigned this Jun 28, 2016
@lewisl9029
Copy link
Contributor

Looks like this issue might be a symptom of a larger problem. There seems to be just a general lack of error handling for async functions in large parts of the codebase. There isn't a single try-catch block in https://github.com/metabase/metabase/blob/master/frontend/src/metabase/dashboard/dashboard.js for instance, even though it has over a dozen await statements.

Is error handling being done somewhere else downstream? Or maybe there is something else that I'm missing? If not, we might want to open another issue to keep note of this as technical debt to be addressed eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants