Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MLv2] Port queries/utils/description.js to MLv2 #28882

Closed
Tracked by #30504
, #30516
...
camsaul opened this issue Mar 3, 2023 · 3 comments · Fixed by #29507
Closed
Tracked by #30504
, #30516
...

[MLv2] Port queries/utils/description.js to MLv2 #28882

camsaul opened this issue Mar 3, 2023 · 3 comments · Fixed by #29507
Assignees
@camsaul
Labels
.Backend .Frontend .metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib .Team/QueryProcessor :hammer_and_wrench:

Comments

@camsaul
Copy link
Member

camsaul commented Mar 3, 2023 •
edited

Braden suggested https://github.com/metabase/metabase/blob/6265ac4fffe4889efa8175cb75fc78d10affaa1a/frontend/src/metabase-lib/queries/utils/description.js as a good file to port over to MLv2. I think porting something sooner rather than later would be a good way to make sure everything is actually working, even from JS land.

We will want to make sure the following issues are done before attempting this:
This was referenced Mar 3, 2023
Closed
Merged
@camsaul camsaul added .Frontend .Backend .metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib labels Mar 3, 2023
@camsaul camsaul mentioned this issue Mar 8, 2023
Closed
@camsaul
Copy link
Member Author

camsaul commented Mar 9, 2023

Fixing this should fix #24703 or at least unblock it

@camsaul camsaul self-assigned this Mar 13, 2023
@camsaul
Copy link
Member Author

camsaul commented Mar 13, 2023

It looks like almost all of the code in description.js is duplicated with similar code in Question.ts -- we should try to port over both at the same time

@camsaul
Copy link
Member Author

camsaul commented Mar 13, 2023

#29192 deletes some of the duplicate stuff in description.js

@camsaul camsaul mentioned this issue Mar 14, 2023
Merged
@darksciencebase darksciencebase added the .Team/QueryProcessor :hammer_and_wrench: label Mar 22, 2023
@camsaul camsaul mentioned this issue Mar 23, 2023
Merged
@darksciencebase darksciencebase mentioned this issue May 3, 2023
Closed
This was referenced Jun 2, 2023
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camsaul camsaul

Labels
.Backend .Frontend .metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib .Team/QueryProcessor :hammer_and_wrench:
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MLv2: Finish porting query description generation metabase/metabase
2 participants
@camsaul @darksciencebase