Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Modal Crashes App When making a new model #28971

Closed
iethree opened this issue Mar 6, 2023 · 1 comment · Fixed by #29278
Closed

Filter Modal Crashes App When making a new model #28971

iethree opened this issue Mar 6, 2023 · 1 comment · Fixed by #29278
Assignees
Labels
.Frontend Priority:P2 Average run of the mill bug Querying/Models aka Datasets Querying/Parameters & Variables Filter widgets, field filters, variables etc. Type:Bug Product defects
Milestone

Comments

@iethree
Copy link
Contributor

iethree commented Mar 6, 2023

Describe the bug

Opening the bulk filter modal on a freshly created model crashes the app. 😢

Logs

BulkFilterModal.tsx:119 Uncaught TypeError: Cannot read properties of undefined (reading 'items')
    at BulkFilterModal (BulkFilterModal.tsx:119:1)
    at renderWithHooks (react-dom.development.js:14803:1)
    at mountIndeterminateComponent (react-dom.development.js:17482:1)
    at beginWork (react-dom.development.js:18596:1)
    at HTMLUnknownElement.callCallback (react-dom.development.js:188:1)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:237:1)
    at invokeGuardedCallback (react-dom.development.js:292:1)
    at beginWork$1 (react-dom.development.js:23203:1)
    at performUnitOfWork (react-dom.development.js:22154:1)
    at workLoopSync (react-dom.development.js:22130:1)

To Reproduce

  1. Global New Menu
  2. Model
  3. Pick any table
  4. Save it
  5. Click Filter
  6. App crashes.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots/videos
filterAppCrash

Information about your Metabase Installation:

{
  "browser-info": {
    "language": "en-US",
    "platform": "MacIntel",
    "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/110.0.0.0 Safari/537.36",
    "vendor": "Google Inc."
  },
  "system-info": {
    "file.encoding": "UTF-8",
    "java.runtime.name": "OpenJDK Runtime Environment",
    "java.runtime.version": "18.0.1+0",
    "java.vendor": "Homebrew",
    "java.vendor.url": "https://github.com/Homebrew/homebrew-core/issues",
    "java.version": "18.0.1",
    "java.vm.name": "OpenJDK 64-Bit Server VM",
    "java.vm.version": "18.0.1+0",
    "os.name": "Mac OS X",
    "os.version": "12.4",
    "user.language": "en",
    "user.timezone": "Europe/Budapest"
  },
  "metabase-info": {
    "databases": [
      "h2",
      "postgres",
      "mysql"
    ],
    "hosting-env": "unknown",
    "application-database": "h2",
    "application-database-details": {
      "database": {
        "name": "H2",
        "version": "2.1.212 (2022-04-09)"
      },
      "jdbc-driver": {
        "name": "H2 JDBC Driver",
        "version": "2.1.212 (2022-04-09)"
      }
    },
    "run-mode": "dev",
    "version": {
      "date": "2023-02-27",
      "src_hash": "35b7029f06bdf5d97b3a143ad718b98edbfccff5",
      "tag": "v0.45.1-SNAPSHOT",
      "branch": "actions/test-times",
      "hash": "6603f1d"
    },
    "settings": {
      "report-timezone": "America/Denver"
    }
  }
}

Severity

Everything is fine after a page refresh, but it's a nasty little surprise for users when we're trying to encourage the use of models.

@iethree iethree added Type:Bug Product defects Priority:P2 Average run of the mill bug labels Mar 6, 2023
@iethree iethree changed the title Filter Modal Crashes App on New Model Filter Modal Crashes App When making a new model Mar 6, 2023
@iethree
Copy link
Contributor Author

iethree commented Mar 6, 2023

This existed in 45 as well. probably introduced by allowing model creation without having a question first.

@iethree iethree added .Frontend Querying/Models aka Datasets Querying/Parameters & Variables Filter widgets, field filters, variables etc. labels Mar 7, 2023
@ranquild ranquild self-assigned this Mar 16, 2023
@ranquild ranquild added this to the 0.46 milestone Apr 5, 2023
This was referenced Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend Priority:P2 Average run of the mill bug Querying/Models aka Datasets Querying/Parameters & Variables Filter widgets, field filters, variables etc. Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants