Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

y-axis is unnecessarily split in static visualizations #29281

Open
EmmadUsmani opened this issue Mar 16, 2023 · 3 comments
Open

y-axis is unnecessarily split in static visualizations #29281

EmmadUsmani opened this issue Mar 16, 2023 · 3 comments
Assignees
Labels
.echarts-scope Issues related to chart types that have already been or will be migrated to echarts. Priority:P2 Average run of the mill bug .Team/DashViz Dashboard and Viz team Type:Bug Product defects Visualization/Charts Line, area, bar, combo, and scatter charts. Visualization/Static Subscriptions/pulse generated image
Milestone

Comments

@EmmadUsmani
Copy link
Contributor

Describe the bug
This essentially the same issue as #12939 but for static visualizations generated for email/slack subscriptions.

When the Split y-axis when necessary setting is enabled on a question, the y-axis will be split in many situations where it is not necessary.

Logs
No logs

To Reproduce

  1. Create a question with a line or bar chart visualization, where the values are close enough to where you wouldn't expect the y-axis to be split.
  2. Setup an email or slack subscription and test it to see the static visualization (or just go to http://localhost:3000/api/pulse/preview_card_png/<card_id>)

Expected behavior
The y-axis should not be split.

Screenshots/videos

27

Information about your Metabase Installation:

{
  "browser-info": {
    "language": "en-US",
    "platform": "MacIntel",
    "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:109.0) Gecko/20100101 Firefox/112.0",
    "vendor": ""
  },
  "system-info": {
    "file.encoding": "UTF-8",
    "java.runtime.name": "OpenJDK Runtime Environment",
    "java.runtime.version": "17.0.6+10",
    "java.vendor": "Eclipse Adoptium",
    "java.vendor.url": "https://adoptium.net/",
    "java.version": "17.0.6",
    "java.vm.name": "OpenJDK 64-Bit Server VM",
    "java.vm.version": "17.0.6+10",
    "os.name": "Mac OS X",
    "os.version": "13.0",
    "user.language": "en",
    "user.timezone": "America/Los_Angeles"
  },
  "metabase-info": {
    "databases": [
      "h2"
    ],
    "hosting-env": "unknown",
    "application-database": "h2",
    "application-database-details": {
      "database": {
        "name": "H2",
        "version": "2.1.214 (2022-06-13)"
      },
      "jdbc-driver": {
        "name": "H2 JDBC Driver",
        "version": "2.1.214 (2022-06-13)"
      }
    },
    "run-mode": "dev",
    "version": {
      "date": "2023-03-14",
      "src_hash": "44a39228b8b0bc137fdac234191433c494d8c2e6",
      "tag": "v0.45.1-SNAPSHOT",
      "branch": "y-split",
      "hash": "13acba8"
    },
    "settings": {
      "report-timezone": null
    }
  }
}

Severity
Somewhat severe, it can make visualizations look very misleading like in the screenshot I provided.

@EmmadUsmani EmmadUsmani added Type:Bug Product defects Priority:P2 Average run of the mill bug Visualization/Charts Line, area, bar, combo, and scatter charts. Visualization/Static Subscriptions/pulse generated image labels Mar 16, 2023
@paoliniluis
Copy link
Contributor

why are you running 45.1?

@EmmadUsmani
Copy link
Contributor Author

@paoliniluis Pretty sure I was on the latest commit on master, I'm not sure why the metadata lists it as 45.1

@Tim-Thomas
Copy link

Tim-Thomas commented Mar 31, 2023

+1 on this issue, we're running into it as well. My ideal would actually be to have the static visualizations respect the same toggle (or have their own version of it) which is slightly different than this issue.

@EmmadUsmani EmmadUsmani added .echarts-scope Issues related to chart types that have already been or will be migrated to echarts. .Team/DashViz Dashboard and Viz team labels Dec 19, 2023
@alxnddr alxnddr self-assigned this Apr 21, 2024
@alxnddr alxnddr added this to the 0.50 milestone Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.echarts-scope Issues related to chart types that have already been or will be migrated to echarts. Priority:P2 Average run of the mill bug .Team/DashViz Dashboard and Viz team Type:Bug Product defects Visualization/Charts Line, area, bar, combo, and scatter charts. Visualization/Static Subscriptions/pulse generated image
Projects
None yet
Development

No branches or pull requests

4 participants