Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Absolute links don't work on link cards when Metabase is on a sub-path #30893

Closed
paoliniluis opened this issue May 20, 2023 · 1 comment · Fixed by #32731
Closed

Absolute links don't work on link cards when Metabase is on a sub-path #30893

paoliniluis opened this issue May 20, 2023 · 1 comment · Fixed by #32731
Assignees
@uladzimirdev
Labels
Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Reporting/Dashboards Type:Bug Product defects
Milestone
0.47

Comments

@paoliniluis
Copy link
Contributor

Describe the bug

Entire repro is on #30891

To Reproduce

  1. set up Metabase on a sub-path with https://github.com/paoliniluis/metabase-subpath
  2. create a dashboard and a link to an absolute URL
  3. try to click that link it won't work

Expected behavior

it should take the user to the absolute path

Logs

No response

Information about your Metabase installation

1.46.2

Severity

P1

Additional context

No response
@paoliniluis paoliniluis mentioned this issue May 20, 2023
Open
@brunobergher brunobergher added the Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness label May 29, 2023
@cdeweyx
Copy link

cdeweyx commented Jul 12, 2023

@ranquild @NevRA Does this make sense for our team to take on? I see it was removed from our board and I can't quite recall why.

@uladzimirdev uladzimirdev self-assigned this Jul 26, 2023
@uladzimirdev uladzimirdev mentioned this issue Jul 28, 2023
Merged
@darksciencebase darksciencebase added this to the 0.47 milestone Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@uladzimirdev uladzimirdev

Labels
Priority:P1 Security holes w/o exploit, crashing, setup/upgrade, login, broken common features, correctness Reporting/Dashboards Type:Bug Product defects
Projects
None yet
Milestone
0.47
Development

Successfully merging a pull request may close this issue.

Handle absolute link for LinkCards on sub-path properly metabase/metabase
7 participants
@brunobergher @NevRA @paoliniluis @ranquild @cdeweyx @darksciencebase @uladzimirdev