Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative links inside tables get encoded characters and fail #30894

Closed
paoliniluis opened this issue May 20, 2023 · 2 comments · Fixed by #43303
Closed

Relative links inside tables get encoded characters and fail #30894

paoliniluis opened this issue May 20, 2023 · 2 comments · Fixed by #43303
Assignees
Labels
.Frontend Priority:P2 Average run of the mill bug .Team/DashViz Dashboard and Viz team Type:Bug Product defects Visualization/Tables Raw, summarized, and pivoted tables
Milestone

Comments

@paoliniluis
Copy link
Contributor

Describe the bug

full repro is on #30891

To Reproduce

  1. create a question
  2. create another question, this question needs to have a relative link to the first question (you can make the link easily with a "concat(relativeurl, "")"
  3. format the relative url as a link in the table
  4. try clicking the link, see that fails because of the encoded character

Expected behavior

why are we encoding certain characters on the table links?

Logs

No response

Information about your Metabase installation

NA

Severity

P2

Additional context

No response

@paoliniluis paoliniluis added Type:Bug Product defects Priority:P2 Average run of the mill bug Visualization/Tables Raw, summarized, and pivoted tables labels May 20, 2023
@EmmadUsmani EmmadUsmani added .Team/DashViz Dashboard and Viz team and removed .Team/PixelPolice (DEPRECATED) labels Dec 20, 2023
@albertoperdomo
Copy link
Member

albertoperdomo commented Apr 16, 2024

I was reproducing this, so leaving here a few tips for reproduction based on my understanding:
After creating the 2nd question with the relative URL, you need to format the column like this (hit cog icon the column header):

image

Even though the link text looks fine, the actual URL is actually encoded.

The URL /question/103-products points to http://localhost:3000/%2Fquestion%2F103-products. It seems the slash symbol is being URL encoded.

@heypoom
Copy link
Contributor

heypoom commented Apr 17, 2024

@albertoperdomo thank you for reproducing this! I wasn't aware that parameters could be applied to the fields, learned something new today 😄

@kulyk kulyk self-assigned this May 29, 2024
@kulyk kulyk added this to the 0.50 milestone May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.Frontend Priority:P2 Average run of the mill bug .Team/DashViz Dashboard and Viz team Type:Bug Product defects Visualization/Tables Raw, summarized, and pivoted tables
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants