Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmark icon should be correct size; and should be filled when an item is bookmarked #34327

Closed
mazameli opened this issue Oct 3, 2023 · 0 comments · Fixed by #38239
Closed
Assignees
Labels
Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/GUI Query builder catch-all, including simple mode .Team/QueryingComponents Type:Bug Product defects
Milestone

Comments

@mazameli
Copy link
Contributor

mazameli commented Oct 3, 2023

Describe the bug

I think this is my own doing as part of the big icons revamp in 0.47, but we should use the filled version of our bookmark icon when an item is bookmarked, not the outlined version that you see here:

image

Additionally, the size of the bookmark icon is too small when viewed on a dashboard, saved question, or model — it should have a viewbox of 20px by 20px (which would result in an effective pixel width and height of approximately 12x17px when scaled up).

To Reproduce

  1. Go to a dashboard or saved question
  2. Bookmark it
  3. See how it is a sad, hollow shell of its once glorious self, yearning to be filled to counter the yawning existential emptiness it feels within. (And it's also a bit too small relative to the other icons.)

Expected behavior

It should be a filled icon when bookmarked, and should be the slightly larger size on the dashboard/question/model page, whether bookmarked or not.

Logs

No response

Information about your Metabase installation

{
  "browser-info": {
    "language": "en-US",
    "platform": "MacIntel",
    "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/117.0.0.0 Safari/537.36",
    "vendor": "Google Inc."
  },
  "system-info": {
    "file.encoding": "UTF-8",
    "java.runtime.name": "OpenJDK Runtime Environment",
    "java.runtime.version": "11.0.11+9",
    "java.vendor": "AdoptOpenJDK",
    "java.vendor.url": "https://adoptopenjdk.net/",
    "java.version": "11.0.11",
    "java.vm.name": "OpenJDK 64-Bit Server VM",
    "java.vm.version": "11.0.11+9",
    "os.name": "Mac OS X",
    "os.version": "11.5",
    "user.language": "en",
    "user.timezone": "America/Los_Angeles"
  },
  "metabase-info": {
    "databases": [
      "h2"
    ],
    "hosting-env": "unknown",
    "application-database": "h2",
    "application-database-details": {
      "database": {
        "name": "H2",
        "version": "2.1.214 (2022-06-13)"
      },
      "jdbc-driver": {
        "name": "H2 JDBC Driver",
        "version": "2.1.214 (2022-06-13)"
      }
    },
    "run-mode": "dev",
    "version": {
      "date": "2022-11-18",
      "src_hash": "09f4ec50c4b6096192e18c140068ce8a7e67434d",
      "tag": "v0.45.1-SNAPSHOT",
      "branch": "maz-make-saving-a-question-less-fear-inducing",
      "hash": "f694966"
    },
    "settings": {
      "report-timezone": null
    }
  }
}

Severity

P3

Additional context

Figma file with proposed solution

image
@mazameli mazameli added Type:Bug Product defects .Needs Triage labels Oct 3, 2023
@ranquild ranquild added Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/GUI Query builder catch-all, including simple mode .Team/42 🌌 and removed .Needs Triage labels Oct 4, 2023
@nemanjaglumac nemanjaglumac self-assigned this Jan 29, 2024
@nemanjaglumac nemanjaglumac added this to the 0.49 milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Querying/GUI Query builder catch-all, including simple mode .Team/QueryingComponents Type:Bug Product defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants