Let's not present usage pop-ups for unsupported functions in custom expression interface #35156
Labels
.Backend
.Frontend
Priority:P2
Average run of the mill bug
Querying/GUI
Query builder catch-all, including simple mode
.Team/QueryingComponents
Type:Bug
Product defects
Milestone
Issue #34993 requires us to fix
percentile
support for mariadb, saying that user tried to use percentile in the custom expression interface but translation to sql which they've got was not right. However we do not support:percentile-expressions
for mariadb on the backend. Let alone, mariadb supports only window version onpercetile_disc
and currently query builder also does not support use of window functions (related issue is #9393).I believe the fact, that they were seeing the usage pop-up after writing in
percentile(
made them think it is something we are able to correctly compute from query builder and that's false.With regards to the completion of function name -- This is something we do not do for unsupported functions and that's right.
Attached screenshots contain (1) no completion when writing
percentile
and (2) pop-up after entring inpercentile(
and (3) completion of arguments that should imo happen only for supported functions.And super ideal behavior would be to not even enable user to generate request for query containing use of a function that is not supported by a driver or make backend return eg. 418 when request like this is processed.
The text was updated successfully, but these errors were encountered: