Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge viz settings correctly #36154

Closed
Tracked by #36015
markbastian opened this issue Nov 27, 2023 · 1 comment
Closed
Tracked by #36015

Merge viz settings correctly #36154

markbastian opened this issue Nov 27, 2023 · 1 comment
Assignees
Labels
no-backport Do not backport this PR to any branch .Team/DashViz Dashboard and Viz team
Milestone

Comments

@markbastian
Copy link
Contributor

markbastian commented Nov 27, 2023

Currently, Viz settings can come from a bunch of locations (see below). The result of this effort should be a unified path, preferably the metabase.query-processor.middleware.visualization-settings/update-viz-settings middleware, that correctly unifies all of the viz settings in one location.

  • Viz settings can come from a bunch of locations:
    - card visualization_settings
    - dashcard visualization_settings
    - defsetting custom-formatting
    - metabase.shared.models.visualization-settings (maybe)
    - defsetting application-colors might also affect static viz rendering (maybe)
  • The metabase.query-processor.middleware.visualization-settings/update-viz-settings middleware is a good candidate to resolve these differences
  • AC
@markbastian markbastian added no-backport Do not backport this PR to any branch .Team/DashViz Dashboard and Viz team labels Nov 27, 2023
@markbastian markbastian removed their assignment Dec 18, 2023
@markbastian markbastian self-assigned this Jan 5, 2024
@markbastian
Copy link
Contributor Author

This has been completed as part of related work.

@markbastian markbastian modified the milestones: 0.48.3, 0.49 Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-backport Do not backport this PR to any branch .Team/DashViz Dashboard and Viz team
Projects
None yet
Development

No branches or pull requests

2 participants