Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a test to prevent serialization bugs with new settings #36240

Closed
calherries opened this issue Nov 30, 2023 · 1 comment · Fixed by #37624
Closed

Create a test to prevent serialization bugs with new settings #36240

calherries opened this issue Nov 30, 2023 · 1 comment · Fixed by #37624
Assignees
Labels
good first issue A starter issue that is good for someone new to the codebase or is a new contributor .Team/BackendComponents also known as BEC Type:New Feature Type:Tech Debt or Refactoring
Milestone

Comments

@calherries
Copy link
Contributor

This bug #36232 happened because we created new settings, but they weren't added to the list of settings to be serialized, when they should have been. We should have a test that forces engineers introducing new settings to choose whether or not to add it to the exported list of settings.

@crisptrutski
Copy link
Contributor

crisptrutski commented Jan 15, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue A starter issue that is good for someone new to the codebase or is a new contributor .Team/BackendComponents also known as BEC Type:New Feature Type:Tech Debt or Refactoring
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants