Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

png export of chart from a dashboard includes the menu ellipsis in the top right corner of the image #36261

Closed
notrom opened this issue Dec 1, 2023 · 3 comments
Labels
Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Reporting/Dashboards Reporting/Export .Team/DashViz Dashboard and Viz team Type:Bug Product defects
Milestone

Comments

@notrom
Copy link

notrom commented Dec 1, 2023

Describe the bug

When exporting a chart png from a dashboard I get the menu button ellipsis included. This isn't a chart element but UI component so I didn't expect it.
E.g.
blah-12_1_2023, 10_08_42 AM

To Reproduce

  1. Go to any dashboard with a chart.
  2. Click on the "..." menu on the chart widget and select "Download results" > ".png"
  3. Open the image downloaded.
  4. "..." on the top right of the image doesn't feel like it should be there.

Expected behavior

No UI components should be included on the png.

Logs

No response

Information about your Metabase installation

{
  "browser-info": {
    "language": "en-NZ",
    "platform": "Win32",
    "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/119.0.0.0 Safari/537.36",
    "vendor": "Google Inc."
  },
  "system-info": {
    "file.encoding": "Cp1252",
    "java.runtime.name": "OpenJDK Runtime Environment",
    "java.runtime.version": "17.0.2+8",
    "java.vendor": "Eclipse Adoptium",
    "java.vendor.url": "https://adoptium.net/",
    "java.version": "17.0.2",
    "java.vm.name": "OpenJDK 64-Bit Server VM",
    "java.vm.version": "17.0.2+8",
    "os.name": "Windows 10",
    "os.version": "10.0",
    "user.language": "en",
    "user.timezone": "UTC"
  },
  "metabase-info": {
    "databases": [
      "h2",
      "postgres",
      "sqlserver"
    ],
    "hosting-env": "unknown",
    "application-database": "postgres",
    "application-database-details": {
      "database": {
        "name": "PostgreSQL",
        "version": "12.1"
      },
      "jdbc-driver": {
        "name": "PostgreSQL JDBC Driver",
        "version": "42.5.4"
      }
    },
    "run-mode": "prod",
    "version": {
      "date": "2023-11-17",
      "tag": "v0.47.8",
      "branch": "?",
      "hash": "639fa5e"
    },
    "settings": {
      "report-timezone": "Pacific/Auckland"
    }
  }
}

Severity

Mildly annoying, does not impact use just feels wrong to me.

Additional context

It doesn't seem to get included on the pdf when exporting the whole dashboard, but you do get the pagination UI components for tables but not scroll bars.

@notrom notrom added .Needs Triage Type:Bug Product defects labels Dec 1, 2023
@paoliniluis paoliniluis added Reporting/Dashboards Reporting/Export Priority:P3 Cosmetic bugs, minor bugs with a clear workaround and removed .Needs Triage labels Dec 1, 2023
@cdeweyx cdeweyx added the .Team/DashViz Dashboard and Viz team label Jan 8, 2024
@kulyk kulyk added this to the 0.49 milestone Mar 5, 2024
@kulyk
Copy link
Member

kulyk commented Mar 5, 2024

Can't reproduce this anymore

@kulyk kulyk closed this as completed Mar 5, 2024
@notrom
Copy link
Author

notrom commented Mar 5, 2024

@kulyk I just upgraded a test environment to v0.48.8 and I still get the ellipsis.

This is the chart in the dashboard:
image

Same repro as above (dashboard > chart ellipsis > Download results > .png) give me this (includes "..." top right):
blah-3_6_2024, 10_12_32 AM

Chrome on windows as above.

Still not a big deal, but does seem to exist for me.

@kulyk
Copy link
Member

kulyk commented Mar 6, 2024

@notrom apologise I was a bit too brief: I couldn't reproduce the issue on the main branch, the fix will be included in the upcoming 49 release. And thank you for the detailed bug report! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:P3 Cosmetic bugs, minor bugs with a clear workaround Reporting/Dashboards Reporting/Export .Team/DashViz Dashboard and Viz team Type:Bug Product defects
Projects
None yet
Development

No branches or pull requests

4 participants