Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MLv2] [BE] Add sourceTableOrCardId(query) #36672

Closed
Tracked by #36983
ranquild opened this issue Dec 12, 2023 · 2 comments · Fixed by #36778
Closed
Tracked by #36983

[MLv2] [BE] Add sourceTableOrCardId(query) #36672

ranquild opened this issue Dec 12, 2023 · 2 comments · Fixed by #36778
Assignees
@metamben
Labels
.metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib .Team/QueryProcessor :hammer_and_wrench:
Milestone
0.49

Comments

@ranquild
Copy link
Contributor

ranquild commented Dec 12, 2023 •
edited
Loading

Should return source-table table id (number) or card id (card__:id string)
@ranquild ranquild mentioned this issue Dec 12, 2023
Closed
@darksciencebase darksciencebase added .metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib .Team/QueryProcessor :hammer_and_wrench: labels Dec 12, 2023
@camsaul
Copy link
Member

camsaul commented Dec 12, 2023 •
edited
Loading

Why do you need/want the card__<id> string? That's a legacy thing, it's not used in MLv2/pMBQL. Is it to hit API endpoints or something? We can just change the API endpoints to take Card IDs instead of the dumb strings we constantly have to parse and unparse

@ranquild
Copy link
Contributor Author

ranquild commented Dec 13, 2023 •
edited
Loading

@camsaul we need this for the DataPicker (the component to select source table / card). Currently it depends on this legacy format. We also need this for some special logic in joins - when the source question is a model, we should open the "models" tab by default.

@uladzimirdev uladzimirdev mentioned this issue Dec 13, 2023
Closed
@metamben metamben self-assigned this Dec 13, 2023
@metamben metamben mentioned this issue Dec 13, 2023
Merged
@ranquild ranquild mentioned this issue Dec 20, 2023
Closed
@metamben metamben added this to the 0.49 milestone Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metamben metamben

Labels
.metabase-lib Label for tracking all issues related to the shared CLJC metabase-lib .Team/QueryProcessor :hammer_and_wrench:
Projects
None yet
Milestone
0.49
Development

Successfully merging a pull request may close this issue.

Add sourceTableOrCardId metabase/metabase
4 participants
@camsaul @ranquild @metamben @darksciencebase