We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Place 1
metabase/frontend/src/metabase/query_builder/components/view/ViewHeader.jsx
Line 96 in b14003c
In MLv2 it could be:
const query = question._getMLv2Query(); const previousQuery = usePrevious(query); useEffect(() => { // existing code const filtersCount = Lib.filters(query, -1).length; const previousFiltersCount = Lib.filters(previousQuery, -1).length; // existing code });
Place 2
Line 110 in b14003c
Lib.aggregations(query, -1).length > 0
For non-mbql queries aggregations would be an empty list.
aggregations
-1 means the last stage of the query.
-1
Place 3
Line 419 in b14003c
MLv2:
const isNewQuery = Lib.sourceTableOrCardId(query) == null;
The content you are editing has changed. Please copy your edits and refresh the page.
ViewTitleHeader
ViewTitleHeaderRightSide
The text was updated successfully, but these errors were encountered:
Migrated steps 1 and 2 from the original issue description. The only outstanding reference to the MLv1 in this file is (step 3):
but we cannot fully migrate it until we start supporting native queries with MLv2.
cc @NevRA
Sorry, something went wrong.
hasData
nemanjaglumac
No branches or pull requests
ViewHeader
Place 1
metabase/frontend/src/metabase/query_builder/components/view/ViewHeader.jsx
Line 96 in b14003c
In MLv2 it could be:
Place 2
metabase/frontend/src/metabase/query_builder/components/view/ViewHeader.jsx
Line 110 in b14003c
In MLv2 it could be:
For non-mbql queries
aggregations
would be an empty list.-1
means the last stage of the query.Place 3
metabase/frontend/src/metabase/query_builder/components/view/ViewHeader.jsx
Line 419 in b14003c
MLv2:
Tasks
ViewTitleHeader
to MLv2 #37375The text was updated successfully, but these errors were encountered: